threads / patch / 14355

patch, 4 partsgit-imap-send: Allow the program to be run from subdirectories of a git tree.

Subject: [PATCH 1/4] git-imap-send: Allow the program to be run from subdirectories of a git tree.

## tl;dr

4 messages between Jul 8, 2008 and Jul 9, 2008. Diffs are folded; open one to read it.

replies: 3people: 3as markdown or json

Robert Shearman· Jul 8, 2008, 22:18 UTC · lore

Call setup_git_directory_gently to allow git-imap-send to be used from subdirectories of a git tree.
---
 imap-send.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Show changes to imap-send.c +1 −0

diff --git a/imap-send.c b/imap-send.c
index 1ec1310..89a1532 100644
--- a/imap-send.c
+++ b/imap-send.c
@@ -1296,6 +1296,7 @@ main(int argc, char **argv)
 	/* init the random number generator */
 	arc4_init();
 
+	setup_git_directory_gently( NULL );
 	git_config(git_imap_config, NULL);
 
 	if (!imap_folder) {

-- 
1.5.6.GIT

Junio C Hamano· Jul 9, 2008, 01:15 UTC · re: Robert Shearman · lore

Re: [PATCH 1/4] git-imap-send: Allow the program to be run from subdirectories of a git tree.

Robert Shearman <robertshearman@gmail.com> writes:

Show 17 quoted lines

> Call setup_git_directory_gently to allow git-imap-send to be used from subdirectories of a git tree.
> ---
>  imap-send.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/imap-send.c b/imap-send.c
> index 1ec1310..89a1532 100644
> --- a/imap-send.c
> +++ b/imap-send.c
> @@ -1296,6 +1296,7 @@ main(int argc, char **argv)
>  	/* init the random number generator */
>  	arc4_init();
>  
> +	setup_git_directory_gently( NULL );
>  	git_config(git_imap_config, NULL);
>  
>  	if (!imap_folder) {

I thought Jeff already explained why this NULL was a bad idea, but perhaps I was dreaming...

Besides, the extra spaces around the argument is very distracting.

Jay Soffian· Jul 9, 2008, 01:28 UTC · re: Junio C Hamano · lore

Re: [PATCH 1/4] git-imap-send: Allow the program to be run from subdirectories of a git tree.

On Tue, Jul 8, 2008 at 9:15 PM, Junio C Hamano <gitster@pobox.com> wrote:

> I thought Jeff already explained why this NULL was a bad idea, but perhaps
> I was dreaming...

http://article.gmane.org/gmane.comp.version-control.git/87701

j.

Rob Shearman· Jul 9, 2008, 12:08 UTC · re: Jay Soffian · lore

Re: [PATCH 1/4] git-imap-send: Allow the program to be run from subdirectories of a git tree.

2008/7/9 Jay Soffian <jaysoffian@gmail.com>:

Show 5 quoted lines

> On Tue, Jul 8, 2008 at 9:15 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> I thought Jeff already explained why this NULL was a bad idea, but perhaps
>> I was dreaming...
>
> http://article.gmane.org/gmane.comp.version-control.git/87701

Sorry, I missed that message. I'll resend the patch with his suggestion.

-- 
Rob Shearman