{"thread":{"id":"14355","subject":"[PATCH 1/4] git-imap-send: Allow the program to be run from subdirectories of a git tree.","startedAt":"2008-07-08T22:18:13Z","lastAt":"2008-07-09T12:08:02Z","messageCount":4,"participants":["Robert Shearman","Junio C Hamano","Jay Soffian","Rob Shearman"],"isPatch":true,"patchVersion":1,"patchTotal":4},"messages":[{"id":"82639","messageId":"1215555496-21335-1-git-send-email-robertshearman@gmail.com","threadId":"14355","inReplyTo":null,"subject":"[PATCH 1/4] git-imap-send: Allow the program to be run from subdirectories of a git tree.","fromName":"Robert Shearman","fromEmail":"robertshearman@gmail.com","sentAt":"2008-07-08T22:18:13Z","receivedAt":"2008-07-08T22:18:13Z","isPatch":true,"sender":{"key":"robertshearman@gmail.com","avatar":null},"body":"Call setup_git_directory_gently to allow git-imap-send to be used from subdirectories of a git tree.\n---\n imap-send.c |    1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/imap-send.c b/imap-send.c\nindex 1ec1310..89a1532 100644\n--- a/imap-send.c\n+++ b/imap-send.c\n@@ -1296,6 +1296,7 @@ main(int argc, char **argv)\n \t/* init the random number generator */\n \tarc4_init();\n \n+\tsetup_git_directory_gently( NULL );\n \tgit_config(git_imap_config, NULL);\n \n \tif (!imap_folder) {\n-- \n1.5.6.GIT\n"},{"id":"82663","messageId":"7v3amjq2mj.fsf@gitster.siamese.dyndns.org","threadId":"14355","inReplyTo":"1215555496-21335-1-git-send-email-robertshearman@gmail.com","subject":"Re: [PATCH 1/4] git-imap-send: Allow the program to be run from subdirectories of a git tree.","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-07-09T01:15:32Z","receivedAt":"2008-07-09T01:15:32Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Robert Shearman <robertshearman@gmail.com> writes:\n\n> Call setup_git_directory_gently to allow git-imap-send to be used from subdirectories of a git tree.\n> ---\n>  imap-send.c |    1 +\n>  1 files changed, 1 insertions(+), 0 deletions(-)\n>\n> diff --git a/imap-send.c b/imap-send.c\n> index 1ec1310..89a1532 100644\n> --- a/imap-send.c\n> +++ b/imap-send.c\n> @@ -1296,6 +1296,7 @@ main(int argc, char **argv)\n>  \t/* init the random number generator */\n>  \tarc4_init();\n>  \n> +\tsetup_git_directory_gently( NULL );\n>  \tgit_config(git_imap_config, NULL);\n>  \n>  \tif (!imap_folder) {\n\nI thought Jeff already explained why this NULL was a bad idea, but perhaps\nI was dreaming...\n\nBesides, the extra spaces around the argument is very distracting.\n"},{"id":"82667","messageId":"76718490807081828k7640d07bp547a69d05a6e07c4@mail.gmail.com","threadId":"14355","inReplyTo":"7v3amjq2mj.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH 1/4] git-imap-send: Allow the program to be run from subdirectories of a git tree.","fromName":"Jay Soffian","fromEmail":"jaysoffian@gmail.com","sentAt":"2008-07-09T01:28:03Z","receivedAt":"2008-07-09T01:28:03Z","isPatch":true,"sender":{"key":"jaysoffian@gmail.com","avatar":"https://avatars.githubusercontent.com/u/155970?v=4"},"body":"On Tue, Jul 8, 2008 at 9:15 PM, Junio C Hamano <gitster@pobox.com> wrote:\n> I thought Jeff already explained why this NULL was a bad idea, but perhaps\n> I was dreaming...\n\nhttp://article.gmane.org/gmane.comp.version-control.git/87701\n\nj.\n"},{"id":"82714","messageId":"1096648c0807090508w5b161dd0xf4fc61a6653b3289@mail.gmail.com","threadId":"14355","inReplyTo":"76718490807081828k7640d07bp547a69d05a6e07c4@mail.gmail.com","subject":"Re: [PATCH 1/4] git-imap-send: Allow the program to be run from subdirectories of a git tree.","fromName":"Rob Shearman","fromEmail":"robertshearman@gmail.com","sentAt":"2008-07-09T12:08:02Z","receivedAt":"2008-07-09T12:08:02Z","isPatch":true,"sender":{"key":"robertshearman@gmail.com","avatar":null},"body":"2008/7/9 Jay Soffian <jaysoffian@gmail.com>:\n> On Tue, Jul 8, 2008 at 9:15 PM, Junio C Hamano <gitster@pobox.com> wrote:\n>> I thought Jeff already explained why this NULL was a bad idea, but perhaps\n>> I was dreaming...\n>\n> http://article.gmane.org/gmane.comp.version-control.git/87701\n\nSorry, I missed that message. I'll resend the patch with his suggestion.\n\n-- \nRob Shearman\n"}]}