Re: [PATCH 1/4] git-imap-send: Allow the program to be run from subdirectories of a git tree.

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 9, 2008, 01:15 UTC
Message-ID: <7v3amjq2mj.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1215555496-21335-1-git-send-email-robertshearman@gmail.com>

Robert Shearman <robertshearman@gmail.com> writes:

Show 17 quoted lines

> Call setup_git_directory_gently to allow git-imap-send to be used from subdirectories of a git tree.
> ---
>  imap-send.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/imap-send.c b/imap-send.c
> index 1ec1310..89a1532 100644
> --- a/imap-send.c
> +++ b/imap-send.c
> @@ -1296,6 +1296,7 @@ main(int argc, char **argv)
>  	/* init the random number generator */
>  	arc4_init();
>  
> +	setup_git_directory_gently( NULL );
>  	git_config(git_imap_config, NULL);
>  
>  	if (!imap_folder) {

I thought Jeff already explained why this NULL was a bad idea, but perhaps I was dreaming...

Besides, the extra spaces around the argument is very distracting.