threads / patch / 14066

patchMove deletion of configure generated files to distclean

Subject: [PATCH] Move deletion of configure generated files to distclean

## tl;dr

4 messages between Jun 21, 2008 and Jun 21, 2008. Diffs are folded; open one to read it.

replies: 3people: 3as markdown or json

shire· Jun 21, 2008, 00:57 UTC · lore

Running "make clean" also requires a run of "./configure ..." again because it deletes auto-generated files, which I found a little unexpected. I figured I'd mention it as I'm not sure if this is confusing for other users or intended functionality of "make clean" vs. "make distclean", I would assume that the first would not revert configuration changes.

Signed-off-by: Brian Shire <shire@tekrat.com>

---
  Makefile |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to Makefile +1 −1

diff --git a/Makefile b/Makefile
index b003e3e..f868b0b 100644
--- a/Makefile
+++ b/Makefile
@@ -1346,6 +1346,7 @@ dist-doc:
  ### Cleaning rules

  distclean: clean
+	$(RM) config.log config.mak.autogen config.mak.append config.status  
config.cache
  	$(RM) configure

  clean:
@@ -1355,7 +1356,6 @@ clean:
  	$(RM) $(TEST_PROGRAMS)
  	$(RM) *.spec *.pyc *.pyo */*.pyc */*.pyo common-cmds.h TAGS tags  
cscope*
  	$(RM) -r autom4te.cache
-	$(RM) config.log config.mak.autogen config.mak.append config.status  
config.cache
  	$(RM) -r $(GIT_TARNAME) .doc-tmp-dir
  	$(RM) $(GIT_TARNAME).tar.gz git-core_$(GIT_VERSION)-*.tar.gz
  	$(RM) $(htmldocs).tar.gz $(manpages).tar.gz

-- 
1.5.6.dirty

Miklos Vajna· Jun 21, 2008, 01:28 UTC · re: shire · lore

Re: [PATCH] Move deletion of configure generated files to distclean

On Fri, Jun 20, 2008 at 05:57:45PM -0700, shire <shire@tekrat.com> wrote:

Show 5 quoted lines

> Running "make clean" also requires a run of "./configure ..." again because 
> it deletes auto-generated files, which I found a little unexpected.  I 
> figured I'd mention it as I'm not sure if this is confusing for other users 
> or intended functionality of "make clean" vs. "make distclean", I would 
> assume that the first would not revert configuration changes.

I remember I was surprised as well when first time I noticed this behaviour, so I like your patch.

Stephan Beyer· Jun 21, 2008, 01:35 UTC · re: shire · lore

Re: [PATCH] Move deletion of configure generated files to distclean

Hi,

whitespace and linebreaks are broken in your patch. (Just noticed because I needed a quick patch to test something and I took yours.)

Regards,
  Stephan

-- 
Stephan Beyer <s-beyer@gmx.net>, PGP 0x6EDDD207FCC5040F

shire· Jun 21, 2008, 07:33 UTC · re: Stephan Beyer · lore

Re: [PATCH] Move deletion of configure generated files to distclean

On Jun 20, 2008, at 6:35 PM, Stephan Beyer wrote:

Show 6 quoted lines

> Hi,
>
> whitespace and linebreaks are broken in your patch.
> (Just noticed because I needed a quick patch to test something and I
> took yours.)
>

Doh, thanks! It appears there's no good simple way around the email body being munged in os x's mail.app, and I was mislead in my initial test email to myself. I'll either fix mail.app in the future or send via some other mailer, I apologize for the obvious mistake despite all the guidelines in the patches file. I've gone ahead and just attached the patch to this email that should apply cleanly with git-am.

From 6c3ec53f54ca346f7fff38ee4ef748cac3c0f488 Mon Sep 17 00:00:00 2001
From: Brian Shire <shire@99-204-10-66.area1.spcsdns.net>
Date: Fri, 20 Jun 2008 17:53:51 -0700
Subject: [PATCH] Move deletion of configure generated files to distclean

---
 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to Makefile +1 −1

diff --git a/Makefile b/Makefile
index b003e3e..f868b0b 100644
--- a/Makefile
+++ b/Makefile
@@ -1346,6 +1346,7 @@ dist-doc:
 ### Cleaning rules
 
 distclean: clean
+	$(RM) config.log config.mak.autogen config.mak.append config.status config.cache
 	$(RM) configure
 
 clean:
@@ -1355,7 +1356,6 @@ clean:
 	$(RM) $(TEST_PROGRAMS)
 	$(RM) *.spec *.pyc *.pyo */*.pyc */*.pyo common-cmds.h TAGS tags cscope*
 	$(RM) -r autom4te.cache
-	$(RM) config.log config.mak.autogen config.mak.append config.status config.cache
 	$(RM) -r $(GIT_TARNAME) .doc-tmp-dir
 	$(RM) $(GIT_TARNAME).tar.gz git-core_$(GIT_VERSION)-*.tar.gz
 	$(RM) $(htmldocs).tar.gz $(manpages).tar.gz

-- 
1.5.6.dirty