{"thread":{"id":"14066","subject":"[PATCH] Move deletion of configure generated files to distclean","startedAt":"2008-06-21T00:57:45Z","lastAt":"2008-06-21T07:33:26Z","messageCount":4,"participants":["shire","Miklos Vajna","Stephan Beyer"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"80524","messageId":"D4D1BF84-3D3F-4DEC-87C0-F926228E0BF5@tekrat.com","threadId":"14066","inReplyTo":null,"subject":"[PATCH] Move deletion of configure generated files to distclean","fromName":"shire","fromEmail":"shire@tekrat.com","sentAt":"2008-06-21T00:57:45Z","receivedAt":"2008-06-21T00:57:45Z","isPatch":true,"sender":{"key":"shire@tekrat.com","avatar":null},"body":"\nRunning \"make clean\" also requires a run of \"./configure ...\" again \nbecause it deletes auto-generated files, which I found a little \nunexpected. I figured I'd mention it as I'm not sure if this is \nconfusing for other users or intended functionality of \"make clean\" \nvs. \"make distclean\", I would assume that the first would not revert \nconfiguration changes.\n\nSigned-off-by: Brian Shire \n\n---\n Makefile | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex b003e3e..f868b0b 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1346,6 +1346,7 @@ dist-doc:\n ### Cleaning rules\n\n distclean: clean\n+\t$(RM) config.log config.mak.autogen config.mak.append config.status \nconfig.cache\n \t$(RM) configure\n\n clean:\n@@ -1355,7 +1356,6 @@ clean:\n \t$(RM) $(TEST_PROGRAMS)\n \t$(RM) *.spec *.pyc *.pyo */*.pyc */*.pyo common-cmds.h TAGS tags \ncscope*\n \t$(RM) -r autom4te.cache\n-\t$(RM) config.log config.mak.autogen config.mak.append config.status \nconfig.cache\n \t$(RM) -r $(GIT_TARNAME) .doc-tmp-dir\n \t$(RM) $(GIT_TARNAME).tar.gz git-core_$(GIT_VERSION)-*.tar.gz\n \t$(RM) $(htmldocs).tar.gz $(manpages).tar.gz\n-- \n1.5.6.dirty\n"},{"id":"80525","messageId":"20080621012824.GG29404@genesis.frugalware.org","threadId":"14066","inReplyTo":"D4D1BF84-3D3F-4DEC-87C0-F926228E0BF5@tekrat.com","subject":"Re: [PATCH] Move deletion of configure generated files to distclean","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2008-06-21T01:28:24Z","receivedAt":"2008-06-21T01:28:24Z","isPatch":true,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"On Fri, Jun 20, 2008 at 05:57:45PM -0700, shire wrote:\n> Running \"make clean\" also requires a run of \"./configure ...\" again because \n> it deletes auto-generated files, which I found a little unexpected. I \n> figured I'd mention it as I'm not sure if this is confusing for other users \n> or intended functionality of \"make clean\" vs. \"make distclean\", I would \n> assume that the first would not revert configuration changes.\n\nI remember I was surprised as well when first time I noticed this\nbehaviour, so I like your patch.\n"},{"id":"80526","messageId":"20080621013547.GF7369@leksak.fem-net","threadId":"14066","inReplyTo":"D4D1BF84-3D3F-4DEC-87C0-F926228E0BF5@tekrat.com","subject":"Re: [PATCH] Move deletion of configure generated files to distclean","fromName":"Stephan Beyer","fromEmail":"s-beyer@gmx.net","sentAt":"2008-06-21T01:35:47Z","receivedAt":"2008-06-21T01:35:47Z","isPatch":true,"sender":{"key":"s-beyer@gmx.net","avatar":"https://avatars.githubusercontent.com/u/143889?v=4"},"body":"Hi,\n\nwhitespace and linebreaks are broken in your patch.\n(Just noticed because I needed a quick patch to test something and I\ntook yours.)\n\nRegards,\n Stephan\n\n-- \nStephan Beyer , PGP 0x6EDDD207FCC5040F\n"},{"id":"80534","messageId":"AC4B20A5-396B-462D-9ACA-4E140B0876E2@tekrat.com","threadId":"14066","inReplyTo":"20080621013547.GF7369@leksak.fem-net","subject":"Re: [PATCH] Move deletion of configure generated files to distclean","fromName":"shire","fromEmail":"shire@tekrat.com","sentAt":"2008-06-21T07:33:26Z","receivedAt":"2008-06-21T07:33:26Z","isPatch":true,"sender":{"key":"shire@tekrat.com","avatar":null},"body":"On Jun 20, 2008, at 6:35 PM, Stephan Beyer wrote:\n\n> Hi,\n>\n> whitespace and linebreaks are broken in your patch.\n> (Just noticed because I needed a quick patch to test something and I\n> took yours.)\n>\n\nDoh, thanks! It appears there's no good simple way around the email \nbody being munged in os x's mail.app, and I was mislead in my initial \ntest email to myself. I'll either fix mail.app in the future or send \nvia some other mailer, I apologize for the obvious mistake despite \nall the guidelines in the patches file. I've gone ahead and just \nattached the patch to this email that should apply cleanly with git-am.\n\n\n\nFrom 6c3ec53f54ca346f7fff38ee4ef748cac3c0f488 Mon Sep 17 00:00:00 2001\nFrom: Brian Shire \nDate: Fri, 20 Jun 2008 17:53:51 -0700\nSubject: [PATCH] Move deletion of configure generated files to distclean\n\n---\n Makefile | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/Makefile b/Makefile\nindex b003e3e..f868b0b 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1346,6 +1346,7 @@ dist-doc:\n ### Cleaning rules\n \n distclean: clean\n+\t$(RM) config.log config.mak.autogen config.mak.append config.status config.cache\n \t$(RM) configure\n \n clean:\n@@ -1355,7 +1356,6 @@ clean:\n \t$(RM) $(TEST_PROGRAMS)\n \t$(RM) *.spec *.pyc *.pyo */*.pyc */*.pyo common-cmds.h TAGS tags cscope*\n \t$(RM) -r autom4te.cache\n-\t$(RM) config.log config.mak.autogen config.mak.append config.status config.cache\n \t$(RM) -r $(GIT_TARNAME) .doc-tmp-dir\n \t$(RM) $(GIT_TARNAME).tar.gz git-core_$(GIT_VERSION)-*.tar.gz\n \t$(RM) $(htmldocs).tar.gz $(manpages).tar.gz\n-- \n1.5.6.dirty\n\n"}]}