# [PATCH] Move deletion of configure generated files to distclean 4 messages from 2008-06-21 to 2008-06-21. Participants: shire, Miklos Vajna, Stephan Beyer. Thread: https://gitlist.dev/t/14066 ## shire, 2008-06-21 00:57 Subject: [PATCH] Move deletion of configure generated files to distclean Message-ID: URL: https://gitlist.dev/e/D4D1BF84-3D3F-4DEC-87C0-F926228E0BF5%40tekrat.com ``` Running "make clean" also requires a run of "./configure ..." again because it deletes auto-generated files, which I found a little unexpected. I figured I'd mention it as I'm not sure if this is confusing for other users or intended functionality of "make clean" vs. "make distclean", I would assume that the first would not revert configuration changes. Signed-off-by: Brian Shire --- Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index b003e3e..f868b0b 100644 --- a/Makefile +++ b/Makefile @@ -1346,6 +1346,7 @@ dist-doc: ### Cleaning rules distclean: clean + $(RM) config.log config.mak.autogen config.mak.append config.status config.cache $(RM) configure clean: @@ -1355,7 +1356,6 @@ clean: $(RM) $(TEST_PROGRAMS) $(RM) *.spec *.pyc *.pyo */*.pyc */*.pyo common-cmds.h TAGS tags cscope* $(RM) -r autom4te.cache - $(RM) config.log config.mak.autogen config.mak.append config.status config.cache $(RM) -r $(GIT_TARNAME) .doc-tmp-dir $(RM) $(GIT_TARNAME).tar.gz git-core_$(GIT_VERSION)-*.tar.gz $(RM) $(htmldocs).tar.gz $(manpages).tar.gz -- 1.5.6.dirty ``` ## Miklos Vajna, 2008-06-21 01:28 Subject: Re: [PATCH] Move deletion of configure generated files to distclean Message-ID: <20080621012824.GG29404@genesis.frugalware.org> URL: https://gitlist.dev/e/20080621012824.GG29404%40genesis.frugalware.org In-Reply-To: ``` On Fri, Jun 20, 2008 at 05:57:45PM -0700, shire wrote: > Running "make clean" also requires a run of "./configure ..." again because > it deletes auto-generated files, which I found a little unexpected. I > figured I'd mention it as I'm not sure if this is confusing for other users > or intended functionality of "make clean" vs. "make distclean", I would > assume that the first would not revert configuration changes. I remember I was surprised as well when first time I noticed this behaviour, so I like your patch. ``` ## Stephan Beyer, 2008-06-21 01:35 Subject: Re: [PATCH] Move deletion of configure generated files to distclean Message-ID: <20080621013547.GF7369@leksak.fem-net> URL: https://gitlist.dev/e/20080621013547.GF7369%40leksak.fem-net In-Reply-To: ``` Hi, whitespace and linebreaks are broken in your patch. (Just noticed because I needed a quick patch to test something and I took yours.) Regards, Stephan -- Stephan Beyer , PGP 0x6EDDD207FCC5040F ``` ## shire, 2008-06-21 07:33 Subject: Re: [PATCH] Move deletion of configure generated files to distclean Message-ID: URL: https://gitlist.dev/e/AC4B20A5-396B-462D-9ACA-4E140B0876E2%40tekrat.com In-Reply-To: <20080621013547.GF7369@leksak.fem-net> ``` On Jun 20, 2008, at 6:35 PM, Stephan Beyer wrote: > Hi, > > whitespace and linebreaks are broken in your patch. > (Just noticed because I needed a quick patch to test something and I > took yours.) > Doh, thanks! It appears there's no good simple way around the email body being munged in os x's mail.app, and I was mislead in my initial test email to myself. I'll either fix mail.app in the future or send via some other mailer, I apologize for the obvious mistake despite all the guidelines in the patches file. I've gone ahead and just attached the patch to this email that should apply cleanly with git-am. From 6c3ec53f54ca346f7fff38ee4ef748cac3c0f488 Mon Sep 17 00:00:00 2001 From: Brian Shire Date: Fri, 20 Jun 2008 17:53:51 -0700 Subject: [PATCH] Move deletion of configure generated files to distclean --- Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index b003e3e..f868b0b 100644 --- a/Makefile +++ b/Makefile @@ -1346,6 +1346,7 @@ dist-doc: ### Cleaning rules distclean: clean + $(RM) config.log config.mak.autogen config.mak.append config.status config.cache $(RM) configure clean: @@ -1355,7 +1356,6 @@ clean: $(RM) $(TEST_PROGRAMS) $(RM) *.spec *.pyc *.pyo */*.pyc */*.pyo common-cmds.h TAGS tags cscope* $(RM) -r autom4te.cache - $(RM) config.log config.mak.autogen config.mak.append config.status config.cache $(RM) -r $(GIT_TARNAME) .doc-tmp-dir $(RM) $(GIT_TARNAME).tar.gz git-core_$(GIT_VERSION)-*.tar.gz $(RM) $(htmldocs).tar.gz $(manpages).tar.gz -- 1.5.6.dirty ```