threads / patch / 14044

patchcompletion: add --graph to log command completion

Subject: [PATCH] completion: add --graph to log command completion

## tl;dr

7 messages between Jun 19, 2008 and Jun 20, 2008. Diffs are folded; open one to read it.

replies: 6people: 3as markdown or json

Dan McGee· Jun 19, 2008, 21:15 UTC · lore

Signed-off-by: Dan McGee <dpmcgee@gmail.com>
---
 contrib/completion/git-completion.bash |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Show changes to contrib/completion/git-completion.bash +1 −0

diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 2141b6b..0eb8df0 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -761,6 +761,7 @@ _git_log ()
 			--pretty= --name-status --name-only --raw
 			--not --all
 			--left-right --cherry-pick
+			--graph
 			"
 		return
 		;;

-- 
1.5.6

Shawn O. Pearce· Jun 19, 2008, 21:58 UTC · re: Dan McGee · lore

Re: [PATCH] completion: add --graph to log command completion

Dan McGee <dpmcgee@gmail.com> wrote:

> Signed-off-by: Dan McGee <dpmcgee@gmail.com>

Acked-by: Shawn O. Pearce <spearce@spearce.org>

First change for 1.5.6.1? With --graph in 1.5.6 we really should have included this as part of 1.5.6. Oh well. 1.5.6.1 perhaps Junio?

Show 18 quoted lines

> ---
>  contrib/completion/git-completion.bash |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 2141b6b..0eb8df0 100755
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -761,6 +761,7 @@ _git_log ()
>  			--pretty= --name-status --name-only --raw
>  			--not --all
>  			--left-right --cherry-pick
> +			--graph
>  			"
>  		return
>  		;;
> -- 
> 1.5.6

-- 
Shawn.

Teemu Likonen· Jun 19, 2008, 22:40 UTC · re: Shawn O. Pearce · lore

Re: [PATCH] completion: add --graph to log command completion

Shawn O. Pearce wrote (2008-06-19 17:58 -0400):

Show 7 quoted lines

> Dan McGee <dpmcgee@gmail.com> wrote:
> > Signed-off-by: Dan McGee <dpmcgee@gmail.com>
> 
> Acked-by: Shawn O. Pearce <spearce@spearce.org>
> 
> First change for 1.5.6.1?  With --graph in 1.5.6 we really should have
> included this as part of 1.5.6.  Oh well.  1.5.6.1 perhaps Junio?

Liked-by: me

I think I have already sent twice a patch with --graph completion. I use bash completions quite a lot and here's my current additions to "git log":

---snip--- bash: Add more option completions for 'git log'

Options added: --graph --walk-reflogs --stat --numstat --shortstat --decorate --diff-filter= --color-words

Signed-off-by: Teemu Likonen <tlikonen@iki.fi>
---
 contrib/completion/git-completion.bash |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

Show changes to contrib/completion/git-completion.bash +3 −0

diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 506b40c..e78ca8e 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -761,6 +761,9 @@ _git_log ()
 			--pretty= --name-status --name-only --raw
 			--not --all
 			--left-right --cherry-pick
+			--stat --numstat --shortstat
+			--decorate --diff-filter=
+			--color-words --walk-reflogs --graph
 			"
 		return
 		;;

-- 
1.5.6.2.g3c3a

Shawn O. Pearce· Jun 19, 2008, 22:55 UTC · re: Teemu Likonen · lore

Re: [PATCH] completion: add --graph to log command completion

Teemu Likonen <tlikonen@iki.fi> wrote:

> I think I have already sent twice a patch with --graph completion.

I didn't Ack them because at the time --graph wasn't even in next yet I think. Then I got busy and forgot. And --graph slipped through into the 1.5.6 release without your bash completion patches. Sorry.

Show 8 quoted lines

> ---snip---
> bash: Add more option completions for 'git log'
> 
> Options added: --graph --walk-reflogs --stat --numstat --shortstat
> --decorate --diff-filter= --color-words
> 
> Signed-off-by: Teemu Likonen <tlikonen@iki.fi>
> ---

This conflicts with the patch you are replying to, but it makes sense to do these options as well.

Acked-by: Shawn O. Pearce <spearce@spearce.org>

assuming the semantic (or merge) conflict on --graph is worked out. ;-)

Show 20 quoted lines

>  contrib/completion/git-completion.bash |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 506b40c..e78ca8e 100755
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -761,6 +761,9 @@ _git_log ()
>  			--pretty= --name-status --name-only --raw
>  			--not --all
>  			--left-right --cherry-pick
> +			--stat --numstat --shortstat
> +			--decorate --diff-filter=
> +			--color-words --walk-reflogs --graph
>  			"
>  		return
>  		;;
> -- 
> 1.5.6.2.g3c3a
>

-- 
Shawn.

Dan McGee· Jun 19, 2008, 23:06 UTC · re: Shawn O. Pearce · lore

Re: [PATCH] completion: add --graph to log command completion

On Thu, Jun 19, 2008 at 5:55 PM, Shawn O. Pearce <spearce@spearce.org> wrote:

> This conflicts with the patch you are replying to, but it makes
> sense to do these options as well.
>
> Acked-by: Shawn O. Pearce <spearce@spearce.org>

It is more complete than mine though, so you can keep my name out of the log this time.

Acked-by: Dan McGee <dpmcgee@gmail.com>

Teemu Likonen· Jun 20, 2008, 06:31 UTC · re: Shawn O. Pearce · lore

Re: [PATCH] completion: add --graph to log command completion

Shawn O. Pearce wrote (2008-06-19 18:55 -0400):

Show 6 quoted lines

> Teemu Likonen <tlikonen@iki.fi> wrote:
> > I think I have already sent twice a patch with --graph completion.
> 
> I didn't Ack them because at the time --graph wasn't even in next yet
> I think.  Then I got busy and forgot.  And --graph slipped through
> into the 1.5.6 release without your bash completion patches. Sorry.

No problems. I should have sent a ping to the list after the log --graph settled to the master branch. But... I forgot.

Teemu Likonen· Jun 20, 2008, 13:02 UTC · re: Teemu Likonen · lore

[PATCH v2] bash: Add more option completions for 'git log'

Options added: --walk-reflogs --stat --numstat --shortstat --decorate --diff-filter= --color-words

Signed-off-by: Teemu Likonen <tlikonen@iki.fi>
---

Here's a non-conflicting version.

 contrib/completion/git-completion.bash |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

Show changes to contrib/completion/git-completion.bash +3 −0

diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 72575cf..f108ede 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -762,6 +762,9 @@ _git_log ()
 			--not --all
 			--left-right --cherry-pick
 			--graph
+			--stat --numstat --shortstat
+			--decorate --diff-filter=
+			--color-words --walk-reflogs
 			"
 		return
 		;;

-- 
1.5.6.2.g3c3a