# [PATCH] completion: add --graph to log command completion 7 messages from 2008-06-19 to 2008-06-20. Participants: Dan McGee, Shawn O. Pearce, Teemu Likonen. Thread: https://gitlist.dev/t/14044 ## Dan McGee, 2008-06-19 21:15 Subject: [PATCH] completion: add --graph to log command completion Message-ID: <1213910153-10679-1-git-send-email-dpmcgee@gmail.com> URL: https://gitlist.dev/e/1213910153-10679-1-git-send-email-dpmcgee%40gmail.com ``` Signed-off-by: Dan McGee --- contrib/completion/git-completion.bash | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index 2141b6b..0eb8df0 100755 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -761,6 +761,7 @@ _git_log () --pretty= --name-status --name-only --raw --not --all --left-right --cherry-pick + --graph " return ;; -- 1.5.6 ``` ## Shawn O. Pearce, 2008-06-19 21:58 Subject: Re: [PATCH] completion: add --graph to log command completion Message-ID: <20080619215842.GL11793@spearce.org> URL: https://gitlist.dev/e/20080619215842.GL11793%40spearce.org In-Reply-To: <1213910153-10679-1-git-send-email-dpmcgee@gmail.com> ``` Dan McGee wrote: > Signed-off-by: Dan McGee Acked-by: Shawn O. Pearce First change for 1.5.6.1? With --graph in 1.5.6 we really should have included this as part of 1.5.6. Oh well. 1.5.6.1 perhaps Junio? > --- > contrib/completion/git-completion.bash | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash > index 2141b6b..0eb8df0 100755 > --- a/contrib/completion/git-completion.bash > +++ b/contrib/completion/git-completion.bash > @@ -761,6 +761,7 @@ _git_log () > --pretty= --name-status --name-only --raw > --not --all > --left-right --cherry-pick > + --graph > " > return > ;; > -- > 1.5.6 -- Shawn. ``` ## Teemu Likonen, 2008-06-19 22:40 Subject: Re: [PATCH] completion: add --graph to log command completion Message-ID: <20080619224012.GA6705@mithlond.arda.local> URL: https://gitlist.dev/e/20080619224012.GA6705%40mithlond.arda.local In-Reply-To: <20080619215842.GL11793@spearce.org> ``` Shawn O. Pearce wrote (2008-06-19 17:58 -0400): > Dan McGee wrote: > > Signed-off-by: Dan McGee > > Acked-by: Shawn O. Pearce > > First change for 1.5.6.1? With --graph in 1.5.6 we really should have > included this as part of 1.5.6. Oh well. 1.5.6.1 perhaps Junio? Liked-by: me I think I have already sent twice a patch with --graph completion. I use bash completions quite a lot and here's my current additions to "git log": ---snip--- bash: Add more option completions for 'git log' Options added: --graph --walk-reflogs --stat --numstat --shortstat --decorate --diff-filter= --color-words Signed-off-by: Teemu Likonen --- contrib/completion/git-completion.bash | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index 506b40c..e78ca8e 100755 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -761,6 +761,9 @@ _git_log () --pretty= --name-status --name-only --raw --not --all --left-right --cherry-pick + --stat --numstat --shortstat + --decorate --diff-filter= + --color-words --walk-reflogs --graph " return ;; -- 1.5.6.2.g3c3a ``` ## Shawn O. Pearce, 2008-06-19 22:55 Subject: Re: [PATCH] completion: add --graph to log command completion Message-ID: <20080619225552.GQ11793@spearce.org> URL: https://gitlist.dev/e/20080619225552.GQ11793%40spearce.org In-Reply-To: <20080619224012.GA6705@mithlond.arda.local> ``` Teemu Likonen wrote: > I think I have already sent twice a patch with --graph completion. I didn't Ack them because at the time --graph wasn't even in next yet I think. Then I got busy and forgot. And --graph slipped through into the 1.5.6 release without your bash completion patches. Sorry. > ---snip--- > bash: Add more option completions for 'git log' > > Options added: --graph --walk-reflogs --stat --numstat --shortstat > --decorate --diff-filter= --color-words > > Signed-off-by: Teemu Likonen > --- This conflicts with the patch you are replying to, but it makes sense to do these options as well. Acked-by: Shawn O. Pearce assuming the semantic (or merge) conflict on --graph is worked out. ;-) > contrib/completion/git-completion.bash | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash > index 506b40c..e78ca8e 100755 > --- a/contrib/completion/git-completion.bash > +++ b/contrib/completion/git-completion.bash > @@ -761,6 +761,9 @@ _git_log () > --pretty= --name-status --name-only --raw > --not --all > --left-right --cherry-pick > + --stat --numstat --shortstat > + --decorate --diff-filter= > + --color-words --walk-reflogs --graph > " > return > ;; > -- > 1.5.6.2.g3c3a > -- Shawn. ``` ## Dan McGee, 2008-06-19 23:06 Subject: Re: [PATCH] completion: add --graph to log command completion Message-ID: <449c10960806191606j547e364er7a231ca879952b13@mail.gmail.com> URL: https://gitlist.dev/e/449c10960806191606j547e364er7a231ca879952b13%40mail.gmail.com In-Reply-To: <20080619225552.GQ11793@spearce.org> ``` On Thu, Jun 19, 2008 at 5:55 PM, Shawn O. Pearce wrote: > This conflicts with the patch you are replying to, but it makes > sense to do these options as well. > > Acked-by: Shawn O. Pearce It is more complete than mine though, so you can keep my name out of the log this time. Acked-by: Dan McGee ``` ## Teemu Likonen, 2008-06-20 06:31 Subject: Re: [PATCH] completion: add --graph to log command completion Message-ID: <20080620063104.GA3307@mithlond.arda.local> URL: https://gitlist.dev/e/20080620063104.GA3307%40mithlond.arda.local In-Reply-To: <20080619225552.GQ11793@spearce.org> ``` Shawn O. Pearce wrote (2008-06-19 18:55 -0400): > Teemu Likonen wrote: > > I think I have already sent twice a patch with --graph completion. > > I didn't Ack them because at the time --graph wasn't even in next yet > I think. Then I got busy and forgot. And --graph slipped through > into the 1.5.6 release without your bash completion patches. Sorry. No problems. I should have sent a ping to the list after the log --graph settled to the master branch. But... I forgot. ``` ## Teemu Likonen, 2008-06-20 13:02 Subject: [PATCH v2] bash: Add more option completions for 'git log' Message-ID: <20080620130210.GA4521@mithlond.arda.local> URL: https://gitlist.dev/e/20080620130210.GA4521%40mithlond.arda.local In-Reply-To: <20080620063104.GA3307@mithlond.arda.local> ``` Options added: --walk-reflogs --stat --numstat --shortstat --decorate --diff-filter= --color-words Signed-off-by: Teemu Likonen --- Here's a non-conflicting version. contrib/completion/git-completion.bash | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index 72575cf..f108ede 100755 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -762,6 +762,9 @@ _git_log () --not --all --left-right --cherry-pick --graph + --stat --numstat --shortstat + --decorate --diff-filter= + --color-words --walk-reflogs " return ;; -- 1.5.6.2.g3c3a ```