{"thread":{"id":"14044","subject":"[PATCH] completion: add --graph to log command completion","startedAt":"2008-06-19T21:15:53Z","lastAt":"2008-06-20T13:02:10Z","messageCount":7,"participants":["Dan McGee","Shawn O. Pearce","Teemu Likonen"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"80373","messageId":"1213910153-10679-1-git-send-email-dpmcgee@gmail.com","threadId":"14044","inReplyTo":null,"subject":"[PATCH] completion: add --graph to log command completion","fromName":"Dan McGee","fromEmail":"dpmcgee@gmail.com","sentAt":"2008-06-19T21:15:53Z","receivedAt":"2008-06-19T21:15:53Z","isPatch":true,"sender":{"key":"dpmcgee@gmail.com","avatar":"https://avatars.githubusercontent.com/u/265817?v=4"},"body":"Signed-off-by: Dan McGee \n---\n contrib/completion/git-completion.bash | 1 +\n 1 files changed, 1 insertions(+), 0 deletions(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 2141b6b..0eb8df0 100755\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -761,6 +761,7 @@ _git_log ()\n \t\t\t--pretty= --name-status --name-only --raw\n \t\t\t--not --all\n \t\t\t--left-right --cherry-pick\n+\t\t\t--graph\n \t\t\t\"\n \t\treturn\n \t\t;;\n-- \n1.5.6\n"},{"id":"80385","messageId":"20080619215842.GL11793@spearce.org","threadId":"14044","inReplyTo":"1213910153-10679-1-git-send-email-dpmcgee@gmail.com","subject":"Re: [PATCH] completion: add --graph to log command completion","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2008-06-19T21:58:42Z","receivedAt":"2008-06-19T21:58:42Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Dan McGee wrote:\n> Signed-off-by: Dan McGee \n\nAcked-by: Shawn O. Pearce \n\nFirst change for 1.5.6.1? With --graph in 1.5.6 we really should\nhave included this as part of 1.5.6. Oh well. 1.5.6.1 perhaps\nJunio?\n\n> ---\n> contrib/completion/git-completion.bash | 1 +\n> 1 files changed, 1 insertions(+), 0 deletions(-)\n> \n> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\n> index 2141b6b..0eb8df0 100755\n> --- a/contrib/completion/git-completion.bash\n> +++ b/contrib/completion/git-completion.bash\n> @@ -761,6 +761,7 @@ _git_log ()\n> \t\t\t--pretty= --name-status --name-only --raw\n> \t\t\t--not --all\n> \t\t\t--left-right --cherry-pick\n> +\t\t\t--graph\n> \t\t\t\"\n> \t\treturn\n> \t\t;;\n> -- \n> 1.5.6\n\n-- \nShawn.\n"},{"id":"80393","messageId":"20080619224012.GA6705@mithlond.arda.local","threadId":"14044","inReplyTo":"20080619215842.GL11793@spearce.org","subject":"Re: [PATCH] completion: add --graph to log command completion","fromName":"Teemu Likonen","fromEmail":"tlikonen@iki.fi","sentAt":"2008-06-19T22:40:12Z","receivedAt":"2008-06-19T22:40:12Z","isPatch":true,"sender":{"key":"tlikonen@iki.fi","avatar":null},"body":"Shawn O. Pearce wrote (2008-06-19 17:58 -0400):\n\n> Dan McGee wrote:\n> > Signed-off-by: Dan McGee \n> \n> Acked-by: Shawn O. Pearce \n> \n> First change for 1.5.6.1? With --graph in 1.5.6 we really should have\n> included this as part of 1.5.6. Oh well. 1.5.6.1 perhaps Junio?\n\nLiked-by: me\n\nI think I have already sent twice a patch with --graph completion. I use\nbash completions quite a lot and here's my current additions to \"git\nlog\":\n\n\n---snip---\nbash: Add more option completions for 'git log'\n\nOptions added: --graph --walk-reflogs --stat --numstat --shortstat\n--decorate --diff-filter= --color-words\n\nSigned-off-by: Teemu Likonen \n---\n contrib/completion/git-completion.bash | 3 +++\n 1 files changed, 3 insertions(+), 0 deletions(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 506b40c..e78ca8e 100755\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -761,6 +761,9 @@ _git_log ()\n \t\t\t--pretty= --name-status --name-only --raw\n \t\t\t--not --all\n \t\t\t--left-right --cherry-pick\n+\t\t\t--stat --numstat --shortstat\n+\t\t\t--decorate --diff-filter=\n+\t\t\t--color-words --walk-reflogs --graph\n \t\t\t\"\n \t\treturn\n \t\t;;\n-- \n1.5.6.2.g3c3a\n"},{"id":"80396","messageId":"20080619225552.GQ11793@spearce.org","threadId":"14044","inReplyTo":"20080619224012.GA6705@mithlond.arda.local","subject":"Re: [PATCH] completion: add --graph to log command completion","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2008-06-19T22:55:52Z","receivedAt":"2008-06-19T22:55:52Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Teemu Likonen wrote:\n> I think I have already sent twice a patch with --graph completion.\n\nI didn't Ack them because at the time --graph wasn't even in next\nyet I think. Then I got busy and forgot. And --graph slipped\nthrough into the 1.5.6 release without your bash completion patches.\nSorry.\n\n> ---snip---\n> bash: Add more option completions for 'git log'\n> \n> Options added: --graph --walk-reflogs --stat --numstat --shortstat\n> --decorate --diff-filter= --color-words\n> \n> Signed-off-by: Teemu Likonen \n> ---\n\nThis conflicts with the patch you are replying to, but it makes\nsense to do these options as well.\n\nAcked-by: Shawn O. Pearce \n\nassuming the semantic (or merge) conflict on --graph is worked out.\n;-)\n\n> contrib/completion/git-completion.bash | 3 +++\n> 1 files changed, 3 insertions(+), 0 deletions(-)\n> \n> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\n> index 506b40c..e78ca8e 100755\n> --- a/contrib/completion/git-completion.bash\n> +++ b/contrib/completion/git-completion.bash\n> @@ -761,6 +761,9 @@ _git_log ()\n> \t\t\t--pretty= --name-status --name-only --raw\n> \t\t\t--not --all\n> \t\t\t--left-right --cherry-pick\n> +\t\t\t--stat --numstat --shortstat\n> +\t\t\t--decorate --diff-filter=\n> +\t\t\t--color-words --walk-reflogs --graph\n> \t\t\t\"\n> \t\treturn\n> \t\t;;\n> -- \n> 1.5.6.2.g3c3a\n> \n\n-- \nShawn.\n"},{"id":"80400","messageId":"449c10960806191606j547e364er7a231ca879952b13@mail.gmail.com","threadId":"14044","inReplyTo":"20080619225552.GQ11793@spearce.org","subject":"Re: [PATCH] completion: add --graph to log command completion","fromName":"Dan McGee","fromEmail":"dpmcgee@gmail.com","sentAt":"2008-06-19T23:06:18Z","receivedAt":"2008-06-19T23:06:18Z","isPatch":true,"sender":{"key":"dpmcgee@gmail.com","avatar":"https://avatars.githubusercontent.com/u/265817?v=4"},"body":"On Thu, Jun 19, 2008 at 5:55 PM, Shawn O. Pearce wrote:\n> This conflicts with the patch you are replying to, but it makes\n> sense to do these options as well.\n>\n> Acked-by: Shawn O. Pearce \n\nIt is more complete than mine though, so you can keep my name out of\nthe log this time.\n\nAcked-by: Dan McGee \n"},{"id":"80438","messageId":"20080620063104.GA3307@mithlond.arda.local","threadId":"14044","inReplyTo":"20080619225552.GQ11793@spearce.org","subject":"Re: [PATCH] completion: add --graph to log command completion","fromName":"Teemu Likonen","fromEmail":"tlikonen@iki.fi","sentAt":"2008-06-20T06:31:04Z","receivedAt":"2008-06-20T06:31:04Z","isPatch":true,"sender":{"key":"tlikonen@iki.fi","avatar":null},"body":"Shawn O. Pearce wrote (2008-06-19 18:55 -0400):\n\n> Teemu Likonen wrote:\n> > I think I have already sent twice a patch with --graph completion.\n> \n> I didn't Ack them because at the time --graph wasn't even in next yet\n> I think. Then I got busy and forgot. And --graph slipped through\n> into the 1.5.6 release without your bash completion patches. Sorry.\n\nNo problems. I should have sent a ping to the list after the log --graph\nsettled to the master branch. But... I forgot.\n"},{"id":"80477","messageId":"20080620130210.GA4521@mithlond.arda.local","threadId":"14044","inReplyTo":"20080620063104.GA3307@mithlond.arda.local","subject":"[PATCH v2] bash: Add more option completions for 'git log'","fromName":"Teemu Likonen","fromEmail":"tlikonen@iki.fi","sentAt":"2008-06-20T13:02:10Z","receivedAt":"2008-06-20T13:02:10Z","isPatch":true,"sender":{"key":"tlikonen@iki.fi","avatar":null},"body":"Options added: --walk-reflogs --stat --numstat --shortstat\n--decorate --diff-filter= --color-words\n\nSigned-off-by: Teemu Likonen \n---\n\nHere's a non-conflicting version.\n\n\n contrib/completion/git-completion.bash | 3 +++\n 1 files changed, 3 insertions(+), 0 deletions(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 72575cf..f108ede 100755\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -762,6 +762,9 @@ _git_log ()\n \t\t\t--not --all\n \t\t\t--left-right --cherry-pick\n \t\t\t--graph\n+\t\t\t--stat --numstat --shortstat\n+\t\t\t--decorate --diff-filter=\n+\t\t\t--color-words --walk-reflogs\n \t\t\t\"\n \t\treturn\n \t\t;;\n-- \n1.5.6.2.g3c3a\n"}]}