threads / patch / 13004

patchAdd interactive option in rebase command completion list.

Subject: [PATCH] Add interactive option in rebase command completion list.

## tl;dr

6 messages between Apr 6, 2008 and Apr 6, 2008. Diffs are folded; open one to read it.

replies: 5people: 4as markdown or json

Pascal Obry· Apr 6, 2008, 17:32 UTC · lore

Signed-off-by: Pascal Obry <pascal@obry.net>
---
 contrib/completion/git-completion.bash |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to contrib/completion/git-completion.bash +1 −1

diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 791e30f..96a712b 100755
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -865,7 +865,7 @@ _git_rebase ()
 		return
 		;;
 	--*)
-		__gitcomp "--onto --merge --strategy"
+		__gitcomp "--onto --merge --strategy --interactive"
 		return
 	esac
 	__gitcomp "$(__git_refs)"

-- 
1.5.5.rc3.7.gba133

Junio C Hamano· Apr 6, 2008, 18:19 UTC · re: Pascal Obry · lore

Re: [PATCH] Add interactive option in rebase command completion list.

Pascal Obry <pascal.obry@gmail.com> writes:

> -		__gitcomp "--onto --merge --strategy"
> +		__gitcomp "--onto --merge --strategy --interactive"

I personally do not think this is worth it where a single "-i" is enough.

Elijah Newren· Apr 6, 2008, 18:33 UTC · re: Junio C Hamano · lore

Re: [PATCH] Add interactive option in rebase command completion list.

On Sun, Apr 6, 2008 at 12:19 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 6 quoted lines

> Pascal Obry <pascal.obry@gmail.com> writes:
>
>  > -             __gitcomp "--onto --merge --strategy"
>  > +             __gitcomp "--onto --merge --strategy --interactive"
>
>  I personally do not think this is worth it where a single "-i" is enough.

One advantage of bash completion, in my opinion, is being able to be reminded of option names by tabbing twice to get a list of possible completions. For exactly such a case, I'd be in favor of this patch.

Just my $0.02, Elijah

Pascal Obry· Apr 6, 2008, 18:46 UTC · re: Junio C Hamano · lore

Re: [PATCH] Add interactive option in rebase command completion list.

Junio C Hamano a écrit :

Show 6 quoted lines

> Pascal Obry <pascal.obry@gmail.com> writes:
> 
>> -		__gitcomp "--onto --merge --strategy"
>> +		__gitcomp "--onto --merge --strategy --interactive"
> 
> I personally do not think this is worth it where a single "-i" is enough.

I like unambiguous name (I do prefer --interactive instead of -i). It is painful to enter so the bash completion come quite handy here. The patch is safe, simple and clean, I see no reason to not include it.

Pascal.

-- 
--|------------------------------------------------------
--| Pascal Obry                           Team-Ada Member
--| 45, rue Gabriel Peri - 78114 Magny Les Hameaux FRANCE
--|------------------------------------------------------
--|              http://www.obry.net
--| "The best way to travel is by means of imagination"
--|
--| gpg --keyserver wwwkeys.pgp.net --recv-key C1082595

Shawn O. Pearce· Apr 6, 2008, 19:09 UTC · re: Pascal Obry · lore

Re: [PATCH] Add interactive option in rebase command completion list.

Pascal Obry <pascal@obry.net> wrote:

Show 11 quoted lines

> Junio C Hamano a écrit :
> >Pascal Obry <pascal.obry@gmail.com> writes:
> >
> >>-		__gitcomp "--onto --merge --strategy"
> >>+		__gitcomp "--onto --merge --strategy --interactive"
> >
> >I personally do not think this is worth it where a single "-i" is enough.
> 
> I like unambiguous name (I do prefer --interactive instead of -i). It is 
> painful to enter so the bash completion come quite handy here. The patch 
> is safe, simple and clean, I see no reason to not include it.

I agree with Pascal here, include the option.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>

-- 
Shawn.

Shawn O. Pearce· Apr 6, 2008, 20:08 UTC · re: Shawn O. Pearce · lore

Re: [PATCH] Add interactive option in rebase command completion list.

"Shawn O. Pearce" <spearce@spearce.org> wrote:

Show 16 quoted lines

> Pascal Obry <pascal@obry.net> wrote:
> > Junio C Hamano a écrit :
> > >Pascal Obry <pascal.obry@gmail.com> writes:
> > >
> > >>-		__gitcomp "--onto --merge --strategy"
> > >>+		__gitcomp "--onto --merge --strategy --interactive"
> > >
> > >I personally do not think this is worth it where a single "-i" is enough.
> > 
> > I like unambiguous name (I do prefer --interactive instead of -i). It is 
> > painful to enter so the bash completion come quite handy here. The patch 
> > is safe, simple and clean, I see no reason to not include it.
> 
> I agree with Pascal here, include the option.
> 
> Signed-off-by: Shawn O. Pearce <spearce@spearce.org>

Gaaaah.

I didn't mean SBO. I mean Acked-by!

Stupid fingers.

-- 
Shawn.