# [PATCH] Add interactive option in rebase command completion list. 6 messages from 2008-04-06 to 2008-04-06. Participants: Pascal Obry, Junio C Hamano, Elijah Newren, Shawn O. Pearce. Thread: https://gitlist.dev/t/13004 ## Pascal Obry, 2008-04-06 17:32 Subject: [PATCH] Add interactive option in rebase command completion list. Message-ID: <1207503144-3008-1-git-send-email-pascal@obry.net> URL: https://gitlist.dev/e/1207503144-3008-1-git-send-email-pascal%40obry.net ``` Signed-off-by: Pascal Obry --- contrib/completion/git-completion.bash | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index 791e30f..96a712b 100755 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -865,7 +865,7 @@ _git_rebase () return ;; --*) - __gitcomp "--onto --merge --strategy" + __gitcomp "--onto --merge --strategy --interactive" return esac __gitcomp "$(__git_refs)" -- 1.5.5.rc3.7.gba133 ``` ## Junio C Hamano, 2008-04-06 18:19 Subject: Re: [PATCH] Add interactive option in rebase command completion list. Message-ID: <7vprt2sv60.fsf@gitster.siamese.dyndns.org> URL: https://gitlist.dev/e/7vprt2sv60.fsf%40gitster.siamese.dyndns.org In-Reply-To: <1207503144-3008-1-git-send-email-pascal@obry.net> ``` Pascal Obry writes: > - __gitcomp "--onto --merge --strategy" > + __gitcomp "--onto --merge --strategy --interactive" I personally do not think this is worth it where a single "-i" is enough. ``` ## Elijah Newren, 2008-04-06 18:33 Subject: Re: [PATCH] Add interactive option in rebase command completion list. Message-ID: <51419b2c0804061133t20f7606y2ebe8f921b6c3781@mail.gmail.com> URL: https://gitlist.dev/e/51419b2c0804061133t20f7606y2ebe8f921b6c3781%40mail.gmail.com In-Reply-To: <7vprt2sv60.fsf@gitster.siamese.dyndns.org> ``` On Sun, Apr 6, 2008 at 12:19 PM, Junio C Hamano wrote: > Pascal Obry writes: > > > - __gitcomp "--onto --merge --strategy" > > + __gitcomp "--onto --merge --strategy --interactive" > > I personally do not think this is worth it where a single "-i" is enough. One advantage of bash completion, in my opinion, is being able to be reminded of option names by tabbing twice to get a list of possible completions. For exactly such a case, I'd be in favor of this patch. Just my $0.02, Elijah ``` ## Pascal Obry, 2008-04-06 18:46 Subject: Re: [PATCH] Add interactive option in rebase command completion list. Message-ID: <47F91A77.5080207@obry.net> URL: https://gitlist.dev/e/47F91A77.5080207%40obry.net In-Reply-To: <7vprt2sv60.fsf@gitster.siamese.dyndns.org> ``` Junio C Hamano a écrit : > Pascal Obry writes: > >> - __gitcomp "--onto --merge --strategy" >> + __gitcomp "--onto --merge --strategy --interactive" > > I personally do not think this is worth it where a single "-i" is enough. I like unambiguous name (I do prefer --interactive instead of -i). It is painful to enter so the bash completion come quite handy here. The patch is safe, simple and clean, I see no reason to not include it. Pascal. -- --|------------------------------------------------------ --| Pascal Obry Team-Ada Member --| 45, rue Gabriel Peri - 78114 Magny Les Hameaux FRANCE --|------------------------------------------------------ --| http://www.obry.net --| "The best way to travel is by means of imagination" --| --| gpg --keyserver wwwkeys.pgp.net --recv-key C1082595 ``` ## Shawn O. Pearce, 2008-04-06 19:09 Subject: Re: [PATCH] Add interactive option in rebase command completion list. Message-ID: <20080406190927.GH10274@spearce.org> URL: https://gitlist.dev/e/20080406190927.GH10274%40spearce.org In-Reply-To: <47F91A77.5080207@obry.net> ``` Pascal Obry wrote: > Junio C Hamano a écrit : > >Pascal Obry writes: > > > >>- __gitcomp "--onto --merge --strategy" > >>+ __gitcomp "--onto --merge --strategy --interactive" > > > >I personally do not think this is worth it where a single "-i" is enough. > > I like unambiguous name (I do prefer --interactive instead of -i). It is > painful to enter so the bash completion come quite handy here. The patch > is safe, simple and clean, I see no reason to not include it. I agree with Pascal here, include the option. Signed-off-by: Shawn O. Pearce -- Shawn. ``` ## Shawn O. Pearce, 2008-04-06 20:08 Subject: Re: [PATCH] Add interactive option in rebase command completion list. Message-ID: <20080406200807.GL10274@spearce.org> URL: https://gitlist.dev/e/20080406200807.GL10274%40spearce.org In-Reply-To: <20080406190927.GH10274@spearce.org> ``` "Shawn O. Pearce" wrote: > Pascal Obry wrote: > > Junio C Hamano a écrit : > > >Pascal Obry writes: > > > > > >>- __gitcomp "--onto --merge --strategy" > > >>+ __gitcomp "--onto --merge --strategy --interactive" > > > > > >I personally do not think this is worth it where a single "-i" is enough. > > > > I like unambiguous name (I do prefer --interactive instead of -i). It is > > painful to enter so the bash completion come quite handy here. The patch > > is safe, simple and clean, I see no reason to not include it. > > I agree with Pascal here, include the option. > > Signed-off-by: Shawn O. Pearce Gaaaah. I didn't mean SBO. I mean Acked-by! Stupid fingers. -- Shawn. ```