{"thread":{"id":"13004","subject":"[PATCH] Add interactive option in rebase command completion list.","startedAt":"2008-04-06T17:32:24Z","lastAt":"2008-04-06T20:08:07Z","messageCount":6,"participants":["Pascal Obry","Junio C Hamano","Elijah Newren","Shawn O. Pearce"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"73751","messageId":"1207503144-3008-1-git-send-email-pascal@obry.net","threadId":"13004","inReplyTo":null,"subject":"[PATCH] Add interactive option in rebase command completion list.","fromName":"Pascal Obry","fromEmail":"pascal.obry@gmail.com","sentAt":"2008-04-06T17:32:24Z","receivedAt":"2008-04-06T17:32:24Z","isPatch":true,"sender":{"key":"pascal@obry.net","avatar":"https://avatars.githubusercontent.com/u/467069?v=4"},"body":"Signed-off-by: Pascal Obry \n---\n contrib/completion/git-completion.bash | 2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 791e30f..96a712b 100755\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -865,7 +865,7 @@ _git_rebase ()\n \t\treturn\n \t\t;;\n \t--*)\n-\t\t__gitcomp \"--onto --merge --strategy\"\n+\t\t__gitcomp \"--onto --merge --strategy --interactive\"\n \t\treturn\n \tesac\n \t__gitcomp \"$(__git_refs)\"\n-- \n1.5.5.rc3.7.gba133\n"},{"id":"73756","messageId":"7vprt2sv60.fsf@gitster.siamese.dyndns.org","threadId":"13004","inReplyTo":"1207503144-3008-1-git-send-email-pascal@obry.net","subject":"Re: [PATCH] Add interactive option in rebase command completion list.","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-04-06T18:19:35Z","receivedAt":"2008-04-06T18:19:35Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Pascal Obry writes:\n\n> -\t\t__gitcomp \"--onto --merge --strategy\"\n> +\t\t__gitcomp \"--onto --merge --strategy --interactive\"\n\nI personally do not think this is worth it where a single \"-i\" is enough.\n"},{"id":"73757","messageId":"51419b2c0804061133t20f7606y2ebe8f921b6c3781@mail.gmail.com","threadId":"13004","inReplyTo":"7vprt2sv60.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] Add interactive option in rebase command completion list.","fromName":"Elijah Newren","fromEmail":"newren@gmail.com","sentAt":"2008-04-06T18:33:29Z","receivedAt":"2008-04-06T18:33:29Z","isPatch":true,"sender":{"key":"newren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5455730?v=4"},"body":"On Sun, Apr 6, 2008 at 12:19 PM, Junio C Hamano wrote:\n> Pascal Obry writes:\n>\n> > - __gitcomp \"--onto --merge --strategy\"\n> > + __gitcomp \"--onto --merge --strategy --interactive\"\n>\n> I personally do not think this is worth it where a single \"-i\" is enough.\n\nOne advantage of bash completion, in my opinion, is being able to be\nreminded of option names by tabbing twice to get a list of possible\ncompletions. For exactly such a case, I'd be in favor of this patch.\n\nJust my $0.02,\nElijah\n"},{"id":"73762","messageId":"47F91A77.5080207@obry.net","threadId":"13004","inReplyTo":"7vprt2sv60.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] Add interactive option in rebase command completion list.","fromName":"Pascal Obry","fromEmail":"pascal@obry.net","sentAt":"2008-04-06T18:46:15Z","receivedAt":"2008-04-06T18:46:15Z","isPatch":true,"sender":{"key":"pascal@obry.net","avatar":"https://avatars.githubusercontent.com/u/467069?v=4"},"body":"Junio C Hamano a écrit :\n> Pascal Obry writes:\n> \n>> -\t\t__gitcomp \"--onto --merge --strategy\"\n>> +\t\t__gitcomp \"--onto --merge --strategy --interactive\"\n> \n> I personally do not think this is worth it where a single \"-i\" is enough.\n\nI like unambiguous name (I do prefer --interactive instead of -i). It is \npainful to enter so the bash completion come quite handy here. The patch \nis safe, simple and clean, I see no reason to not include it.\n\nPascal.\n\n-- \n\n--|------------------------------------------------------\n--| Pascal Obry Team-Ada Member\n--| 45, rue Gabriel Peri - 78114 Magny Les Hameaux FRANCE\n--|------------------------------------------------------\n--| http://www.obry.net\n--| \"The best way to travel is by means of imagination\"\n--|\n--| gpg --keyserver wwwkeys.pgp.net --recv-key C1082595\n"},{"id":"73765","messageId":"20080406190927.GH10274@spearce.org","threadId":"13004","inReplyTo":"47F91A77.5080207@obry.net","subject":"Re: [PATCH] Add interactive option in rebase command completion list.","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2008-04-06T19:09:27Z","receivedAt":"2008-04-06T19:09:27Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"Pascal Obry wrote:\n> Junio C Hamano a écrit :\n> >Pascal Obry writes:\n> >\n> >>-\t\t__gitcomp \"--onto --merge --strategy\"\n> >>+\t\t__gitcomp \"--onto --merge --strategy --interactive\"\n> >\n> >I personally do not think this is worth it where a single \"-i\" is enough.\n> \n> I like unambiguous name (I do prefer --interactive instead of -i). It is \n> painful to enter so the bash completion come quite handy here. The patch \n> is safe, simple and clean, I see no reason to not include it.\n\nI agree with Pascal here, include the option.\n\nSigned-off-by: Shawn O. Pearce \n\n-- \nShawn.\n"},{"id":"73768","messageId":"20080406200807.GL10274@spearce.org","threadId":"13004","inReplyTo":"20080406190927.GH10274@spearce.org","subject":"Re: [PATCH] Add interactive option in rebase command completion list.","fromName":"Shawn O. Pearce","fromEmail":"spearce@spearce.org","sentAt":"2008-04-06T20:08:07Z","receivedAt":"2008-04-06T20:08:07Z","isPatch":true,"sender":{"key":"spearce@spearce.org","avatar":"https://avatars.githubusercontent.com/u/34844?v=4"},"body":"\"Shawn O. Pearce\" wrote:\n> Pascal Obry wrote:\n> > Junio C Hamano a écrit :\n> > >Pascal Obry writes:\n> > >\n> > >>-\t\t__gitcomp \"--onto --merge --strategy\"\n> > >>+\t\t__gitcomp \"--onto --merge --strategy --interactive\"\n> > >\n> > >I personally do not think this is worth it where a single \"-i\" is enough.\n> > \n> > I like unambiguous name (I do prefer --interactive instead of -i). It is \n> > painful to enter so the bash completion come quite handy here. The patch \n> > is safe, simple and clean, I see no reason to not include it.\n> \n> I agree with Pascal here, include the option.\n> \n> Signed-off-by: Shawn O. Pearce \n\nGaaaah.\n\nI didn't mean SBO. I mean Acked-by!\n\nStupid fingers.\n\n-- \nShawn.\n"}]}