threads / patch / 12052

patchcontrib/hooks/post-receive-email: checks for gitweb.description

Subject: [PATCH] contrib/hooks/post-receive-email: checks for gitweb.description

## tl;dr

5 messages between Feb 12, 2008 and Feb 18, 2008. Diffs are folded; open one to read it.

replies: 4people: 3as markdown or json

Bruno Ribas· Feb 12, 2008, 03:25 UTC · lore

Check repository configuration gitweb.description for project description, if $GIT_DIR/description does not exist

Signed-off-by: Bruno Ribas <ribas@c3sl.ufpr.br>
---
 contrib/hooks/post-receive-email |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

Show changes to contrib/hooks/post-receive-email +5 −1

diff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email
index 77c88eb..bdd21fa 100644
--- a/contrib/hooks/post-receive-email
+++ b/contrib/hooks/post-receive-email
@@ -614,7 +614,11 @@ if [ -z "$GIT_DIR" ]; then
 	exit 1
 fi
 
-projectdesc=$(sed -ne '1p' "$GIT_DIR/description")
+if [ -f "$GIT_DIR/description" ]; then
+	projectdesc=$(sed -ne '1p' "$GIT_DIR/description")
+else
+	projectdesc=$(git-config gitweb.description)
+fi
 # Check if the description is unchanged from it's default, and shorten it to
 # a more manageable length if it is
 if expr "$projectdesc" : "Unnamed repository.*$" >/dev/null

-- 
1.5.4.24.gce08d

Jakub Narebski· Feb 12, 2008, 08:17 UTC · re: Bruno Ribas · lore

Re: [PATCH] contrib/hooks/post-receive-email: checks for gitweb.description

Bruno Ribas <ribas@c3sl.ufpr.br> writes:

Show 5 quoted lines

> -projectdesc=$(sed -ne '1p' "$GIT_DIR/description")
> +if [ -f "$GIT_DIR/description" ]; then
> +	projectdesc=$(sed -ne '1p' "$GIT_DIR/description")
> +else
> +	projectdesc=$(git-config gitweb.description)

  +	projectdesc=$(git config gitweb.description)

Show 6 quoted lines

> +fi
>  # Check if the description is unchanged from it's default, and shorten it to
>  # a more manageable length if it is
>  if expr "$projectdesc" : "Unnamed repository.*$" >/dev/null
> -- 
> 1.5.4.24.gce08d

(but this can be fixed when applying).

-- 
Jakub Narebski
Poland
ShadeHawk on #git

Bruno Cesar Ribas· Feb 13, 2008, 00:24 UTC · re: Jakub Narebski · lore

Re: [PATCH] contrib/hooks/post-receive-email: checks for gitweb.description

I can resend with no problem =)

On Tue, Feb 12, 2008 at 12:17:57AM -0800, Jakub Narebski wrote:

Show 27 quoted lines

> Bruno Ribas <ribas@c3sl.ufpr.br> writes:
> 
> > -projectdesc=$(sed -ne '1p' "$GIT_DIR/description")
> > +if [ -f "$GIT_DIR/description" ]; then
> > +	projectdesc=$(sed -ne '1p' "$GIT_DIR/description")
> > +else
> > +	projectdesc=$(git-config gitweb.description)
> 
>   +	projectdesc=$(git config gitweb.description)
> 
> > +fi
> >  # Check if the description is unchanged from it's default, and shorten it to
> >  # a more manageable length if it is
> >  if expr "$projectdesc" : "Unnamed repository.*$" >/dev/null
> > -- 
> > 1.5.4.24.gce08d
> 
> (but this can be fixed when applying).
> 
> -- 
> Jakub Narebski
> Poland
> ShadeHawk on #git
> -
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Bruno Ribas - ribas@c3sl.ufpr.br
http://web.inf.ufpr.br/ribas
C3SL: http://www.c3sl.ufpr.br

Bruno Cesar Ribas· Feb 18, 2008, 03:46 UTC · re: Bruno Cesar Ribas · lore

Re: [PATCH] contrib/hooks/post-receive-email: checks for gitweb.description

Forgoten?! 8^) On Tue, Feb 12, 2008 at 10:24:40PM -0200, Bruno Cesar Ribas wrote:

Show 39 quoted lines

> I can resend with no problem =)
> 
> On Tue, Feb 12, 2008 at 12:17:57AM -0800, Jakub Narebski wrote:
> > Bruno Ribas <ribas@c3sl.ufpr.br> writes:
> > 
> > > -projectdesc=$(sed -ne '1p' "$GIT_DIR/description")
> > > +if [ -f "$GIT_DIR/description" ]; then
> > > +	projectdesc=$(sed -ne '1p' "$GIT_DIR/description")
> > > +else
> > > +	projectdesc=$(git-config gitweb.description)
> > 
> >   +	projectdesc=$(git config gitweb.description)
> > 
> > > +fi
> > >  # Check if the description is unchanged from it's default, and shorten it to
> > >  # a more manageable length if it is
> > >  if expr "$projectdesc" : "Unnamed repository.*$" >/dev/null
> > > -- 
> > > 1.5.4.24.gce08d
> > 
> > (but this can be fixed when applying).
> > 
> > -- 
> > Jakub Narebski
> > Poland
> > ShadeHawk on #git
> > -
> > To unsubscribe from this list: send the line "unsubscribe git" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> -- 
> Bruno Ribas - ribas@c3sl.ufpr.br
> http://web.inf.ufpr.br/ribas
> C3SL: http://www.c3sl.ufpr.br 
> -
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Bruno Ribas - ribas@c3sl.ufpr.br
http://web.inf.ufpr.br/ribas
C3SL: http://www.c3sl.ufpr.br

Junio C Hamano· Feb 18, 2008, 06:03 UTC · re: Bruno Cesar Ribas · lore

Re: [PATCH] contrib/hooks/post-receive-email: checks for gitweb.description

Bruno Cesar Ribas <ribas@c3sl.ufpr.br> writes:

> Forgoten?! 8^)
> On Tue, Feb 12, 2008 at 10:24:40PM -0200, Bruno Cesar Ribas wrote:
>> I can resend with no problem =)

More like "not so much interested myself, although I did not have strong objection either".

Typically original author or people who would see much value in the patch than myself have more incentive and motivation to keep pushing for inclusion of such a patch, so I tend to trust them to re-send saying "Here is the final for inclusion, the list concensus was favorable, and I addressed all the issues raised during the discussion." if they still care about the patch than actively fishing for old patches from my mailbox.

On the other hand if such re-push never happens that is a good indication that nobody is convinced strongly enough to stand behind the patch, and my time is better spent elsewhere.