{"thread":{"id":"12052","subject":"[PATCH] contrib/hooks/post-receive-email: checks for gitweb.description","startedAt":"2008-02-12T03:25:46Z","lastAt":"2008-02-18T06:03:41Z","messageCount":5,"participants":["Bruno Ribas","Jakub Narebski","Bruno Cesar Ribas","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"68482","messageId":"1202786746-12890-1-git-send-email-ribas@c3sl.ufpr.br","threadId":"12052","inReplyTo":null,"subject":"[PATCH] contrib/hooks/post-receive-email: checks for gitweb.description","fromName":"Bruno Ribas","fromEmail":"ribas@c3sl.ufpr.br","sentAt":"2008-02-12T03:25:46Z","receivedAt":"2008-02-12T03:25:46Z","isPatch":true,"sender":{"key":"ribas@c3sl.ufpr.br","avatar":null},"body":"Check repository configuration gitweb.description for project description,\nif $GIT_DIR/description does not exist\n\nSigned-off-by: Bruno Ribas \n---\n contrib/hooks/post-receive-email | 6 +++++-\n 1 files changed, 5 insertions(+), 1 deletions(-)\n\ndiff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email\nindex 77c88eb..bdd21fa 100644\n--- a/contrib/hooks/post-receive-email\n+++ b/contrib/hooks/post-receive-email\n@@ -614,7 +614,11 @@ if [ -z \"$GIT_DIR\" ]; then\n \texit 1\n fi\n \n-projectdesc=$(sed -ne '1p' \"$GIT_DIR/description\")\n+if [ -f \"$GIT_DIR/description\" ]; then\n+\tprojectdesc=$(sed -ne '1p' \"$GIT_DIR/description\")\n+else\n+\tprojectdesc=$(git-config gitweb.description)\n+fi\n # Check if the description is unchanged from it's default, and shorten it to\n # a more manageable length if it is\n if expr \"$projectdesc\" : \"Unnamed repository.*$\" >/dev/null\n-- \n1.5.4.24.gce08d\n"},{"id":"68493","messageId":"m3wspad1xd.fsf@localhost.localdomain","threadId":"12052","inReplyTo":"1202786746-12890-1-git-send-email-ribas@c3sl.ufpr.br","subject":"Re: [PATCH] contrib/hooks/post-receive-email: checks for gitweb.description","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2008-02-12T08:17:57Z","receivedAt":"2008-02-12T08:17:57Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Bruno Ribas writes:\n\n> -projectdesc=$(sed -ne '1p' \"$GIT_DIR/description\")\n> +if [ -f \"$GIT_DIR/description\" ]; then\n> +\tprojectdesc=$(sed -ne '1p' \"$GIT_DIR/description\")\n> +else\n> +\tprojectdesc=$(git-config gitweb.description)\n\n +\tprojectdesc=$(git config gitweb.description)\n\n> +fi\n> # Check if the description is unchanged from it's default, and shorten it to\n> # a more manageable length if it is\n> if expr \"$projectdesc\" : \"Unnamed repository.*$\" >/dev/null\n> -- \n> 1.5.4.24.gce08d\n\n(but this can be fixed when applying).\n\n-- \nJakub Narebski\nPoland\nShadeHawk on #git\n"},{"id":"68577","messageId":"20080213002439.GA31455@c3sl.ufpr.br","threadId":"12052","inReplyTo":"m3wspad1xd.fsf@localhost.localdomain","subject":"Re: [PATCH] contrib/hooks/post-receive-email: checks for gitweb.description","fromName":"Bruno Cesar Ribas","fromEmail":"ribas@c3sl.ufpr.br","sentAt":"2008-02-13T00:24:40Z","receivedAt":"2008-02-13T00:24:40Z","isPatch":true,"sender":{"key":"ribas@c3sl.ufpr.br","avatar":null},"body":"I can resend with no problem =)\n\nOn Tue, Feb 12, 2008 at 12:17:57AM -0800, Jakub Narebski wrote:\n> Bruno Ribas writes:\n> \n> > -projectdesc=$(sed -ne '1p' \"$GIT_DIR/description\")\n> > +if [ -f \"$GIT_DIR/description\" ]; then\n> > +\tprojectdesc=$(sed -ne '1p' \"$GIT_DIR/description\")\n> > +else\n> > +\tprojectdesc=$(git-config gitweb.description)\n> \n> +\tprojectdesc=$(git config gitweb.description)\n> \n> > +fi\n> > # Check if the description is unchanged from it's default, and shorten it to\n> > # a more manageable length if it is\n> > if expr \"$projectdesc\" : \"Unnamed repository.*$\" >/dev/null\n> > -- \n> > 1.5.4.24.gce08d\n> \n> (but this can be fixed when applying).\n> \n> -- \n> Jakub Narebski\n> Poland\n> ShadeHawk on #git\n> -\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at http://vger.kernel.org/majordomo-info.html\n\n-- \nBruno Ribas - ribas@c3sl.ufpr.br\nhttp://web.inf.ufpr.br/ribas\nC3SL: http://www.c3sl.ufpr.br \n"},{"id":"69083","messageId":"20080218034659.GA21776@c3sl.ufpr.br","threadId":"12052","inReplyTo":"20080213002439.GA31455@c3sl.ufpr.br","subject":"Re: [PATCH] contrib/hooks/post-receive-email: checks for gitweb.description","fromName":"Bruno Cesar Ribas","fromEmail":"ribas@c3sl.ufpr.br","sentAt":"2008-02-18T03:46:59Z","receivedAt":"2008-02-18T03:46:59Z","isPatch":true,"sender":{"key":"ribas@c3sl.ufpr.br","avatar":null},"body":"Forgoten?! 8^)\nOn Tue, Feb 12, 2008 at 10:24:40PM -0200, Bruno Cesar Ribas wrote:\n> I can resend with no problem =)\n> \n> On Tue, Feb 12, 2008 at 12:17:57AM -0800, Jakub Narebski wrote:\n> > Bruno Ribas writes:\n> > \n> > > -projectdesc=$(sed -ne '1p' \"$GIT_DIR/description\")\n> > > +if [ -f \"$GIT_DIR/description\" ]; then\n> > > +\tprojectdesc=$(sed -ne '1p' \"$GIT_DIR/description\")\n> > > +else\n> > > +\tprojectdesc=$(git-config gitweb.description)\n> > \n> > +\tprojectdesc=$(git config gitweb.description)\n> > \n> > > +fi\n> > > # Check if the description is unchanged from it's default, and shorten it to\n> > > # a more manageable length if it is\n> > > if expr \"$projectdesc\" : \"Unnamed repository.*$\" >/dev/null\n> > > -- \n> > > 1.5.4.24.gce08d\n> > \n> > (but this can be fixed when applying).\n> > \n> > -- \n> > Jakub Narebski\n> > Poland\n> > ShadeHawk on #git\n> > -\n> > To unsubscribe from this list: send the line \"unsubscribe git\" in\n> > the body of a message to majordomo@vger.kernel.org\n> > More majordomo info at http://vger.kernel.org/majordomo-info.html\n> \n> -- \n> Bruno Ribas - ribas@c3sl.ufpr.br\n> http://web.inf.ufpr.br/ribas\n> C3SL: http://www.c3sl.ufpr.br \n> -\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at http://vger.kernel.org/majordomo-info.html\n\n-- \nBruno Ribas - ribas@c3sl.ufpr.br\nhttp://web.inf.ufpr.br/ribas\nC3SL: http://www.c3sl.ufpr.br \n"},{"id":"69090","messageId":"7vwsp2ssw2.fsf@gitster.siamese.dyndns.org","threadId":"12052","inReplyTo":"20080218034659.GA21776@c3sl.ufpr.br","subject":"Re: [PATCH] contrib/hooks/post-receive-email: checks for gitweb.description","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2008-02-18T06:03:41Z","receivedAt":"2008-02-18T06:03:41Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Bruno Cesar Ribas writes:\n\n> Forgoten?! 8^)\n> On Tue, Feb 12, 2008 at 10:24:40PM -0200, Bruno Cesar Ribas wrote:\n>> I can resend with no problem =)\n\nMore like \"not so much interested myself, although I did not\nhave strong objection either\".\n\nTypically original author or people who would see much value in\nthe patch than myself have more incentive and motivation to keep\npushing for inclusion of such a patch, so I tend to trust them\nto re-send saying \"Here is the final for inclusion, the list\nconcensus was favorable, and I addressed all the issues raised\nduring the discussion.\" if they still care about the patch than\nactively fishing for old patches from my mailbox.\n\nOn the other hand if such re-push never happens that is a good\nindication that nobody is convinced strongly enough to stand\nbehind the patch, and my time is better spent elsewhere.\n"}]}