# [PATCH] contrib/hooks/post-receive-email: checks for gitweb.description 5 messages from 2008-02-12 to 2008-02-18. Participants: Bruno Ribas, Jakub Narebski, Bruno Cesar Ribas, Junio C Hamano. Thread: https://gitlist.dev/t/12052 ## Bruno Ribas, 2008-02-12 03:25 Subject: [PATCH] contrib/hooks/post-receive-email: checks for gitweb.description Message-ID: <1202786746-12890-1-git-send-email-ribas@c3sl.ufpr.br> URL: https://gitlist.dev/e/1202786746-12890-1-git-send-email-ribas%40c3sl.ufpr.br ``` Check repository configuration gitweb.description for project description, if $GIT_DIR/description does not exist Signed-off-by: Bruno Ribas --- contrib/hooks/post-receive-email | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email index 77c88eb..bdd21fa 100644 --- a/contrib/hooks/post-receive-email +++ b/contrib/hooks/post-receive-email @@ -614,7 +614,11 @@ if [ -z "$GIT_DIR" ]; then exit 1 fi -projectdesc=$(sed -ne '1p' "$GIT_DIR/description") +if [ -f "$GIT_DIR/description" ]; then + projectdesc=$(sed -ne '1p' "$GIT_DIR/description") +else + projectdesc=$(git-config gitweb.description) +fi # Check if the description is unchanged from it's default, and shorten it to # a more manageable length if it is if expr "$projectdesc" : "Unnamed repository.*$" >/dev/null -- 1.5.4.24.gce08d ``` ## Jakub Narebski, 2008-02-12 08:17 Subject: Re: [PATCH] contrib/hooks/post-receive-email: checks for gitweb.description Message-ID: URL: https://gitlist.dev/e/m3wspad1xd.fsf%40localhost.localdomain In-Reply-To: <1202786746-12890-1-git-send-email-ribas@c3sl.ufpr.br> ``` Bruno Ribas writes: > -projectdesc=$(sed -ne '1p' "$GIT_DIR/description") > +if [ -f "$GIT_DIR/description" ]; then > + projectdesc=$(sed -ne '1p' "$GIT_DIR/description") > +else > + projectdesc=$(git-config gitweb.description) + projectdesc=$(git config gitweb.description) > +fi > # Check if the description is unchanged from it's default, and shorten it to > # a more manageable length if it is > if expr "$projectdesc" : "Unnamed repository.*$" >/dev/null > -- > 1.5.4.24.gce08d (but this can be fixed when applying). -- Jakub Narebski Poland ShadeHawk on #git ``` ## Bruno Cesar Ribas, 2008-02-13 00:24 Subject: Re: [PATCH] contrib/hooks/post-receive-email: checks for gitweb.description Message-ID: <20080213002439.GA31455@c3sl.ufpr.br> URL: https://gitlist.dev/e/20080213002439.GA31455%40c3sl.ufpr.br In-Reply-To: ``` I can resend with no problem =) On Tue, Feb 12, 2008 at 12:17:57AM -0800, Jakub Narebski wrote: > Bruno Ribas writes: > > > -projectdesc=$(sed -ne '1p' "$GIT_DIR/description") > > +if [ -f "$GIT_DIR/description" ]; then > > + projectdesc=$(sed -ne '1p' "$GIT_DIR/description") > > +else > > + projectdesc=$(git-config gitweb.description) > > + projectdesc=$(git config gitweb.description) > > > +fi > > # Check if the description is unchanged from it's default, and shorten it to > > # a more manageable length if it is > > if expr "$projectdesc" : "Unnamed repository.*$" >/dev/null > > -- > > 1.5.4.24.gce08d > > (but this can be fixed when applying). > > -- > Jakub Narebski > Poland > ShadeHawk on #git > - > To unsubscribe from this list: send the line "unsubscribe git" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Bruno Ribas - ribas@c3sl.ufpr.br http://web.inf.ufpr.br/ribas C3SL: http://www.c3sl.ufpr.br ``` ## Bruno Cesar Ribas, 2008-02-18 03:46 Subject: Re: [PATCH] contrib/hooks/post-receive-email: checks for gitweb.description Message-ID: <20080218034659.GA21776@c3sl.ufpr.br> URL: https://gitlist.dev/e/20080218034659.GA21776%40c3sl.ufpr.br In-Reply-To: <20080213002439.GA31455@c3sl.ufpr.br> ``` Forgoten?! 8^) On Tue, Feb 12, 2008 at 10:24:40PM -0200, Bruno Cesar Ribas wrote: > I can resend with no problem =) > > On Tue, Feb 12, 2008 at 12:17:57AM -0800, Jakub Narebski wrote: > > Bruno Ribas writes: > > > > > -projectdesc=$(sed -ne '1p' "$GIT_DIR/description") > > > +if [ -f "$GIT_DIR/description" ]; then > > > + projectdesc=$(sed -ne '1p' "$GIT_DIR/description") > > > +else > > > + projectdesc=$(git-config gitweb.description) > > > > + projectdesc=$(git config gitweb.description) > > > > > +fi > > > # Check if the description is unchanged from it's default, and shorten it to > > > # a more manageable length if it is > > > if expr "$projectdesc" : "Unnamed repository.*$" >/dev/null > > > -- > > > 1.5.4.24.gce08d > > > > (but this can be fixed when applying). > > > > -- > > Jakub Narebski > > Poland > > ShadeHawk on #git > > - > > To unsubscribe from this list: send the line "unsubscribe git" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- > Bruno Ribas - ribas@c3sl.ufpr.br > http://web.inf.ufpr.br/ribas > C3SL: http://www.c3sl.ufpr.br > - > To unsubscribe from this list: send the line "unsubscribe git" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Bruno Ribas - ribas@c3sl.ufpr.br http://web.inf.ufpr.br/ribas C3SL: http://www.c3sl.ufpr.br ``` ## Junio C Hamano, 2008-02-18 06:03 Subject: Re: [PATCH] contrib/hooks/post-receive-email: checks for gitweb.description Message-ID: <7vwsp2ssw2.fsf@gitster.siamese.dyndns.org> URL: https://gitlist.dev/e/7vwsp2ssw2.fsf%40gitster.siamese.dyndns.org In-Reply-To: <20080218034659.GA21776@c3sl.ufpr.br> ``` Bruno Cesar Ribas writes: > Forgoten?! 8^) > On Tue, Feb 12, 2008 at 10:24:40PM -0200, Bruno Cesar Ribas wrote: >> I can resend with no problem =) More like "not so much interested myself, although I did not have strong objection either". Typically original author or people who would see much value in the patch than myself have more incentive and motivation to keep pushing for inclusion of such a patch, so I tend to trust them to re-send saying "Here is the final for inclusion, the list concensus was favorable, and I addressed all the issues raised during the discussion." if they still care about the patch than actively fishing for old patches from my mailbox. On the other hand if such re-push never happens that is a good indication that nobody is convinced strongly enough to stand behind the patch, and my time is better spent elsewhere. ```