threads / discuss / 11807

Wishlist: Please add --author to git-tag

Subject: Wishlist: Please add --author to git-tag

## tl;dr

7 messages between Jan 31, 2008 and Feb 18, 2008.

replies: 6people: 6as markdown or json

Daniel Baumann· Jan 31, 2008, 17:27 UTC · lore

Hi,

git commit supports --author to overwrite the author information on a particular commit; it would be nice if git tag would offer the same.

Regards, Daniel

-- 
Address:        Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email:          daniel.baumann@panthera-systems.net
Internet:       http://people.panthera-systems.net/~daniel-baumann/

Pierre Habouzit· Jan 31, 2008, 19:35 UTC · re: Daniel Baumann · lore

Re: Wishlist: Please add --author to git-tag

On Thu, Jan 31, 2008 at 05:27:31PM +0000, Daniel Baumann wrote:

> Hi,
> 
> git commit supports --author to overwrite the author information on a
> particular commit; it would be nice if git tag would offer the same.

  Meanwhile,

  GIT_AUTHOR_NAME="John Doe" GIT_AUTHOR_EMAIL=luser@example.com git tag

  Will work

-- 
·O·  Pierre Habouzit
··O                                                madcoder@debian.org
OOO                                                http://www.madism.org

Carlos Rica· Jan 31, 2008, 22:49 UTC · re: Pierre Habouzit · lore

Re: Wishlist: Please add --author to git-tag

On Jan 31, 2008 8:35 PM, Pierre Habouzit <madcoder@debian.org> wrote:

Show 9 quoted lines

> On Thu, Jan 31, 2008 at 05:27:31PM +0000, Daniel Baumann wrote:
> > Hi,
> >
> > git commit supports --author to overwrite the author information on a
> > particular commit; it would be nice if git tag would offer the same.
>
>   Meanwhile,
>
>   GIT_AUTHOR_NAME="John Doe" GIT_AUTHOR_EMAIL=luser@example.com git tag

That didn't work for me, but perhaps I'm not understanding what this user wants to do. I think it is about to create a tag object having another author different from committer.

In such case, and looking at builtin-commit.c, I see that the code needed could came from the function determine_author_info(), just the part using force_author variable, to be added in the create_tag() function from builtin-tag.c.

The only thing I don't know is if this should be different from git-commit in which both "author" and "committer" fields are supplied and only "author" can be changed this way, preserving the committer. In git-tag, only the committer is included in the tag object, written as the "tagger".

Please, correct me if I'm wrong.

Regards. Carlos.

Johannes Schindelin· Jan 31, 2008, 23:48 UTC · re: Carlos Rica · lore

Re: Wishlist: Please add --author to git-tag

Hi,

On Thu, 31 Jan 2008, Carlos Rica wrote:

Show 12 quoted lines

> On Jan 31, 2008 8:35 PM, Pierre Habouzit <madcoder@debian.org> wrote:
> > On Thu, Jan 31, 2008 at 05:27:31PM +0000, Daniel Baumann wrote:
> >
> > > git commit supports --author to overwrite the author information on 
> > > a particular commit; it would be nice if git tag would offer the 
> > > same.
> >
> >   Meanwhile,
> >
> >   GIT_AUTHOR_NAME="John Doe" GIT_AUTHOR_EMAIL=luser@example.com git tag
> 
> That didn't work for me,

Hey jasam, good to see you again.

I think that you have to use "-s" or "-a" for the author information to take effect (IOW a lightweight tag will not pick it up, since it is only a 41-byte file, and does not change the object database).

Ciao, Dscho

Carlos Rica· Feb 1, 2008, 14:48 UTC · re: Johannes Schindelin · lore

Re: Wishlist: Please add --author to git-tag

On Feb 1, 2008 12:48 AM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 22 quoted lines

> Hi,
>
> On Thu, 31 Jan 2008, Carlos Rica wrote:
>
> > On Jan 31, 2008 8:35 PM, Pierre Habouzit <madcoder@debian.org> wrote:
> > > On Thu, Jan 31, 2008 at 05:27:31PM +0000, Daniel Baumann wrote:
> > >
> > > > git commit supports --author to overwrite the author information on
> > > > a particular commit; it would be nice if git tag would offer the
> > > > same.
> > >
> > >   Meanwhile,
> > >
> > >   GIT_AUTHOR_NAME="John Doe" GIT_AUTHOR_EMAIL=luser@example.com git tag
> >
> > That didn't work for me,
>
> Hey jasam, good to see you again.
>
> I think that you have to use "-s" or "-a" for the author information to
> take effect (IOW a lightweight tag will not pick it up, since it is only a
> 41-byte file, and does not change the object database).

This way it doesn't work for me either. You know, the tag object has only a "tagger", who is always the committer. Currently, I'm inspecting the resulting object using "git cat-file tag t". I cannot find where that author name specified in the command line should be stored for tags.

It is nice to see you too! Carlos

Rhodes, Kate· Feb 16, 2008, 19:49 UTC · re: Daniel Baumann · lore

Re: Wishlist: Please add --author to git-tag

On Jan 31, 2008, at 12:27 PM, Daniel Baumann wrote:

> git commit supports --author to overwrite the author information on a
> particular commit; it would be nice if git tag would offer the same.

What are the implications of this on the GPG signature aspect of git- tag (desired or otherwise)?

If you were committing someone else's tag wouldn't you want to sign not only the commit, but their signature on the commit?

Ignoring the GPG issue, I'm just not seeing the benefit to having an author AND a committer on a tag. I mean... it's a *tag*. The only value I see in having any name associated with a tag is knowing who to point the finger at when the wrong thing gets tagged. But, I don't see any authorship aspect to the concept of a tag. To me it's more: "Bob" set it and it points to this. The end.

What you're proposing sounds more like: "Bob" said to set it and then "Mary" did, because Bob said to.

P.S. When the right thing is tagged there's generally no need to know who did it. I don't care if Linus tags the latest kernel release or one of his lieutenants. All I care is that everyone's in agreement that whatever that tag points to is the next release. Who tags something doesn't change the value of what was tagged.

-masukomi

Nicolas Pitre· Feb 18, 2008, 00:00 UTC · re: Rhodes, Kate · lore

Re: Wishlist: Please add --author to git-tag

On Sat, 16 Feb 2008, Rhodes, Kate wrote:

Show 21 quoted lines

> 
> On Jan 31, 2008, at 12:27 PM, Daniel Baumann wrote:
> 
> > git commit supports --author to overwrite the author information on a
> > particular commit; it would be nice if git tag would offer the same.
> 
> What are the implications of this on the GPG signature aspect of git-tag
> (desired or otherwise)?
> 
> If you were committing someone else's tag wouldn't you want to sign not only
> the commit, but their signature on the commit?
> 
> Ignoring the GPG issue, I'm just not seeing the benefit to having an author
> AND a committer on a tag. I mean... it's a *tag*. The only value I see in
> having any name associated with a tag is knowing who to point the finger at
> when the wrong thing gets tagged. But, I don't see any authorship aspect to
> the concept of a tag. To me it's more: "Bob" set it and it points to this. The
> end.
> 
> What you're proposing sounds more like: "Bob" said to set it and then "Mary"
> did, because Bob said to.

And in that case this information can be contained in the tag text body itself.

Nicolas