Re: Wishlist: Please add --author to git-tag

From: Carlos Rica <jasampler@gmail.com>
Date: Jan 31, 2008, 22:49 UTC
Message-ID: <1b46aba20801311449l774a6213kc33c49c0682c0228@mail.gmail.com>
In-Reply-To: <20080131193550.GB10905@artemis.madism.org>

On Jan 31, 2008 8:35 PM, Pierre Habouzit <madcoder@debian.org> wrote:

Show 9 quoted lines

> On Thu, Jan 31, 2008 at 05:27:31PM +0000, Daniel Baumann wrote:
> > Hi,
> >
> > git commit supports --author to overwrite the author information on a
> > particular commit; it would be nice if git tag would offer the same.
>
>   Meanwhile,
>
>   GIT_AUTHOR_NAME="John Doe" GIT_AUTHOR_EMAIL=luser@example.com git tag

That didn't work for me, but perhaps I'm not understanding what this user wants to do. I think it is about to create a tag object having another author different from committer.

In such case, and looking at builtin-commit.c, I see that the code needed could came from the function determine_author_info(), just the part using force_author variable, to be added in the create_tag() function from builtin-tag.c.

The only thing I don't know is if this should be different from git-commit in which both "author" and "committer" fields are supplied and only "author" can be changed this way, preserving the committer. In git-tag, only the committer is included in the tag object, written as the "tagger".

Please, correct me if I'm wrong.

Regards. Carlos.