threads / discuss / 11666

fast-import.c: zlib_compression_level vs pack_compression_level

Subject: fast-import.c: zlib_compression_level vs pack_compression_level

## tl;dr

3 messages between Jan 18, 2008 and Jan 19, 2008.

replies: 2people: 2as markdown or json

Marco Costalba· Jan 18, 2008, 13:04 UTC · lore

Just a small thing I would like to bring to your attention before 1.5.4 is out

During my work on compression/decompression cleanup I have found that in fast-import.c the zlib_compression_level is used, while in builtin-pack-objects is used pack_compression_level instead.

This 2 flags corresponds, more or less directly, (some cleanup is needed also in that area, but this is another story) to:

core.loosecompression

and

pack.compression

config settings.

My question is, does fast-import should use pack.compression instead of core.loosecompression?

Thanks Marco

Nicolas Pitre· Jan 18, 2008, 15:44 UTC · re: Marco Costalba · lore

Re: fast-import.c: zlib_compression_level vs pack_compression_level

On Fri, 18 Jan 2008, Marco Costalba wrote:

> My question is, does fast-import should use pack.compression instead
> of core.loosecompression?

Yes it should.

Nicolas

Marco Costalba· Jan 19, 2008, 08:47 UTC · re: Nicolas Pitre · lore

Re: fast-import.c: zlib_compression_level vs pack_compression_level

On Jan 18, 2008 4:44 PM, Nicolas Pitre <nico@cam.org> wrote:

Show 7 quoted lines

> On Fri, 18 Jan 2008, Marco Costalba wrote:
>
> > My question is, does fast-import should use pack.compression instead
> > of core.loosecompression?
>
> Yes it should.
>

I have a patch on top of my comrpession cleanup series, if people agree I would leave this as is now. It's really not a biggie and 1.5.4 _seems_ very near.

Marco