# fast-import.c: zlib_compression_level vs pack_compression_level 3 messages from 2008-01-18 to 2008-01-19. Participants: Marco Costalba, Nicolas Pitre. Thread: https://gitlist.dev/t/11666 ## Marco Costalba, 2008-01-18 13:04 Subject: fast-import.c: zlib_compression_level vs pack_compression_level Message-ID: URL: https://gitlist.dev/e/e5bfff550801180504v17df7976x59d12f210efe583e%40mail.gmail.com ``` Just a small thing I would like to bring to your attention before 1.5.4 is out During my work on compression/decompression cleanup I have found that in fast-import.c the zlib_compression_level is used, while in builtin-pack-objects is used pack_compression_level instead. This 2 flags corresponds, more or less directly, (some cleanup is needed also in that area, but this is another story) to: core.loosecompression and pack.compression config settings. My question is, does fast-import should use pack.compression instead of core.loosecompression? Thanks Marco ``` ## Nicolas Pitre, 2008-01-18 15:44 Subject: Re: fast-import.c: zlib_compression_level vs pack_compression_level Message-ID: URL: https://gitlist.dev/e/alpine.LFD.1.00.0801181043100.25841%40xanadu.home In-Reply-To: ``` On Fri, 18 Jan 2008, Marco Costalba wrote: > My question is, does fast-import should use pack.compression instead > of core.loosecompression? Yes it should. Nicolas ``` ## Marco Costalba, 2008-01-19 08:47 Subject: Re: fast-import.c: zlib_compression_level vs pack_compression_level Message-ID: URL: https://gitlist.dev/e/e5bfff550801190047n5616b252w4d1c5802343af864%40mail.gmail.com In-Reply-To: ``` On Jan 18, 2008 4:44 PM, Nicolas Pitre wrote: > On Fri, 18 Jan 2008, Marco Costalba wrote: > > > My question is, does fast-import should use pack.compression instead > > of core.loosecompression? > > Yes it should. > I have a patch on top of my comrpession cleanup series, if people agree I would leave this as is now. It's really not a biggie and 1.5.4 _seems_ very near. Marco ```