{"thread":{"id":"11666","subject":"fast-import.c: zlib_compression_level vs pack_compression_level","startedAt":"2008-01-18T13:04:30Z","lastAt":"2008-01-19T08:47:36Z","messageCount":3,"participants":["Marco Costalba","Nicolas Pitre"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"65870","messageId":"e5bfff550801180504v17df7976x59d12f210efe583e@mail.gmail.com","threadId":"11666","inReplyTo":null,"subject":"fast-import.c: zlib_compression_level vs pack_compression_level","fromName":"Marco Costalba","fromEmail":"mcostalba@gmail.com","sentAt":"2008-01-18T13:04:30Z","receivedAt":"2008-01-18T13:04:30Z","isPatch":false,"sender":{"key":"mcostalba@gmail.com","avatar":null},"body":"Just a small thing I would like to bring to your attention before 1.5.4 is out\n\nDuring my work on compression/decompression cleanup I have found that\nin fast-import.c the zlib_compression_level is used, while in\nbuiltin-pack-objects is used pack_compression_level instead.\n\nThis 2 flags corresponds, more or less directly, (some cleanup is\nneeded also in that area, but this is another story) to:\n\ncore.loosecompression\n\nand\n\npack.compression\n\nconfig settings.\n\nMy question is, does fast-import should use pack.compression instead\nof core.loosecompression?\n\nThanks\nMarco\n"},{"id":"65887","messageId":"alpine.LFD.1.00.0801181043100.25841@xanadu.home","threadId":"11666","inReplyTo":"e5bfff550801180504v17df7976x59d12f210efe583e@mail.gmail.com","subject":"Re: fast-import.c: zlib_compression_level vs pack_compression_level","fromName":"Nicolas Pitre","fromEmail":"nico@cam.org","sentAt":"2008-01-18T15:44:02Z","receivedAt":"2008-01-18T15:44:02Z","isPatch":false,"sender":{"key":"nico@fluxnic.net","avatar":"https://avatars.githubusercontent.com/u/702790?v=4"},"body":"On Fri, 18 Jan 2008, Marco Costalba wrote:\n\n> My question is, does fast-import should use pack.compression instead\n> of core.loosecompression?\n\nYes it should.\n\n\nNicolas\n"},{"id":"65946","messageId":"e5bfff550801190047n5616b252w4d1c5802343af864@mail.gmail.com","threadId":"11666","inReplyTo":"alpine.LFD.1.00.0801181043100.25841@xanadu.home","subject":"Re: fast-import.c: zlib_compression_level vs pack_compression_level","fromName":"Marco Costalba","fromEmail":"mcostalba@gmail.com","sentAt":"2008-01-19T08:47:36Z","receivedAt":"2008-01-19T08:47:36Z","isPatch":false,"sender":{"key":"mcostalba@gmail.com","avatar":null},"body":"On Jan 18, 2008 4:44 PM, Nicolas Pitre <nico@cam.org> wrote:\n> On Fri, 18 Jan 2008, Marco Costalba wrote:\n>\n> > My question is, does fast-import should use pack.compression instead\n> > of core.loosecompression?\n>\n> Yes it should.\n>\n\nI have a patch on top of my comrpession cleanup series, if people\nagree I would leave this as is now. It's really not a biggie and 1.5.4\n_seems_ very near.\n\n\nMarco\n"}]}