[PATCH] ls-remote: add -t and -h options.

Miklos Vajna· Jan 15, 2008, 20:34 UTC · lore

These options are listed in the manpage (aliases for --tags/--heads) but they were not handled.

Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>
---

Alternatively, if it's too late to introduce new options, I think we should remove these options from the manpage, but I prefer the current fix.

 builtin-ls-remote.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Show changes to builtin-ls-remote.c +2 −2

diff --git a/builtin-ls-remote.c b/builtin-ls-remote.c
index c2caeea..6dd31d1 100644
--- a/builtin-ls-remote.c
+++ b/builtin-ls-remote.c
@@ -54,11 +54,11 @@ int cmd_ls_remote(int argc, const char **argv, const char *prefix)
 				uploadpack = arg + 7;
 				continue;
 			}
-			if (!strcmp("--tags", arg)) {
+			if (!strcmp("--tags", arg) || !strcmp("-t", arg)) {
 				flags |= REF_TAGS;
 				continue;
 			}
-			if (!strcmp("--heads", arg)) {
+			if (!strcmp("--heads", arg) || !strcmp("-h", arg)) {
 				flags |= REF_HEADS;
 				continue;
 			}

-- 
1.5.4.rc3.4.g16335-dirty

Johannes Schindelin· Jan 16, 2008, 00:12 UTC · re: Miklos Vajna · lore

Re: [PATCH] ls-remote: add -t and -h options.

Hi,

On Tue, 15 Jan 2008, Miklos Vajna wrote:

Show 9 quoted lines

> These options are listed in the manpage (aliases for --tags/--heads) but 
> they were not handled.
> 
> Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>
> ---
> 
> Alternatively, if it's too late to introduce new options, I think we 
> should remove these options from the manpage, but I prefer the current 
> fix.

It's not like you added functionality, but just short option handling. IMHO this is perfectly okay, even this late in the 1.5.4 cycle.

Ciao, Dscho

patchls-remote: add -t and -h options.