# [PATCH] ls-remote: add -t and -h options. 2 messages from 2008-01-15 to 2008-01-16. Participants: Miklos Vajna, Johannes Schindelin. Thread: https://gitlist.dev/t/11631 ## Miklos Vajna, 2008-01-15 20:34 Subject: [PATCH] ls-remote: add -t and -h options. Message-ID: <20080115203454.GU29972@genesis.frugalware.org> URL: https://gitlist.dev/e/20080115203454.GU29972%40genesis.frugalware.org ``` These options are listed in the manpage (aliases for --tags/--heads) but they were not handled. Signed-off-by: Miklos Vajna --- Alternatively, if it's too late to introduce new options, I think we should remove these options from the manpage, but I prefer the current fix. builtin-ls-remote.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/builtin-ls-remote.c b/builtin-ls-remote.c index c2caeea..6dd31d1 100644 --- a/builtin-ls-remote.c +++ b/builtin-ls-remote.c @@ -54,11 +54,11 @@ int cmd_ls_remote(int argc, const char **argv, const char *prefix) uploadpack = arg + 7; continue; } - if (!strcmp("--tags", arg)) { + if (!strcmp("--tags", arg) || !strcmp("-t", arg)) { flags |= REF_TAGS; continue; } - if (!strcmp("--heads", arg)) { + if (!strcmp("--heads", arg) || !strcmp("-h", arg)) { flags |= REF_HEADS; continue; } -- 1.5.4.rc3.4.g16335-dirty ``` ## Johannes Schindelin, 2008-01-16 00:12 Subject: Re: [PATCH] ls-remote: add -t and -h options. Message-ID: URL: https://gitlist.dev/e/alpine.LSU.1.00.0801160011310.17650%40racer.site In-Reply-To: <20080115203454.GU29972@genesis.frugalware.org> ``` Hi, On Tue, 15 Jan 2008, Miklos Vajna wrote: > These options are listed in the manpage (aliases for --tags/--heads) but > they were not handled. > > Signed-off-by: Miklos Vajna > --- > > Alternatively, if it's too late to introduce new options, I think we > should remove these options from the manpage, but I prefer the current > fix. It's not like you added functionality, but just short option handling. IMHO this is perfectly okay, even this late in the 1.5.4 cycle. Ciao, Dscho ```