{"thread":{"id":"11631","subject":"[PATCH] ls-remote: add -t and -h options.","startedAt":"2008-01-15T20:34:54Z","lastAt":"2008-01-16T00:12:32Z","messageCount":2,"participants":["Miklos Vajna","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"65414","messageId":"20080115203454.GU29972@genesis.frugalware.org","threadId":"11631","inReplyTo":null,"subject":"[PATCH] ls-remote: add -t and -h options.","fromName":"Miklos Vajna","fromEmail":"vmiklos@frugalware.org","sentAt":"2008-01-15T20:34:54Z","receivedAt":"2008-01-15T20:34:54Z","isPatch":true,"sender":{"key":"vmiklos@frugalware.org","avatar":"https://gravatar.com/avatar/401c1cbbb3a5d13e650c691a2c71d6fd0b80df1a01bc74d9f1972675dd58f2bd?d=mp&s=160"},"body":"These options are listed in the manpage (aliases for --tags/--heads) but they\nwere not handled.\n\nSigned-off-by: Miklos Vajna <vmiklos@frugalware.org>\n---\n\nAlternatively, if it's too late to introduce new options, I think we should\nremove these options from the manpage, but I prefer the current fix.\n\n builtin-ls-remote.c |    4 ++--\n 1 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/builtin-ls-remote.c b/builtin-ls-remote.c\nindex c2caeea..6dd31d1 100644\n--- a/builtin-ls-remote.c\n+++ b/builtin-ls-remote.c\n@@ -54,11 +54,11 @@ int cmd_ls_remote(int argc, const char **argv, const char *prefix)\n \t\t\t\tuploadpack = arg + 7;\n \t\t\t\tcontinue;\n \t\t\t}\n-\t\t\tif (!strcmp(\"--tags\", arg)) {\n+\t\t\tif (!strcmp(\"--tags\", arg) || !strcmp(\"-t\", arg)) {\n \t\t\t\tflags |= REF_TAGS;\n \t\t\t\tcontinue;\n \t\t\t}\n-\t\t\tif (!strcmp(\"--heads\", arg)) {\n+\t\t\tif (!strcmp(\"--heads\", arg) || !strcmp(\"-h\", arg)) {\n \t\t\t\tflags |= REF_HEADS;\n \t\t\t\tcontinue;\n \t\t\t}\n-- \n1.5.4.rc3.4.g16335-dirty\n"},{"id":"65439","messageId":"alpine.LSU.1.00.0801160011310.17650@racer.site","threadId":"11631","inReplyTo":"20080115203454.GU29972@genesis.frugalware.org","subject":"Re: [PATCH] ls-remote: add -t and -h options.","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2008-01-16T00:12:32Z","receivedAt":"2008-01-16T00:12:32Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nOn Tue, 15 Jan 2008, Miklos Vajna wrote:\n\n> These options are listed in the manpage (aliases for --tags/--heads) but \n> they were not handled.\n> \n> Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>\n> ---\n> \n> Alternatively, if it's too late to introduce new options, I think we \n> should remove these options from the manpage, but I prefer the current \n> fix.\n\nIt's not like you added functionality, but just short option handling.  \nIMHO this is perfectly okay, even this late in the 1.5.4 cycle.\n\nCiao,\nDscho\n"}]}