threads / patch / 11023

patchgitweb: the commitdiff is very commonly used, it's needed on search page, too

Subject: [PATCH] gitweb: the commitdiff is very commonly used, it's needed on search page, too

## tl;dr

3 messages between Nov 26, 2007 and Dec 1, 2007. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Denis Cheng· Nov 26, 2007, 12:42 UTC · lore

---
 gitweb/gitweb.perl |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Show changes to gitweb/gitweb.perl +2 −0

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 491a3f4..ff5daa7 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -3786,6 +3786,8 @@ sub git_search_grep_body {
 		      "<td class=\"link\">" .
 		      $cgi->a({-href => href(action=>"commit", hash=>$co{'id'})}, "commit") .
 		      " | " .
+		      $cgi->a({-href => href(action=>"commitdiff", hash=>$co{'id'})}, "commitdiff") .
+		      " | " .
 		      $cgi->a({-href => href(action=>"tree", hash=>$co{'tree'}, hash_base=>$co{'id'})}, "tree");
 		print "</td>\n" .
 		      "</tr>\n";

-- 
1.5.3.4

Junio C Hamano· Dec 1, 2007, 02:36 UTC · re: Denis Cheng · lore

Re: [PATCH] gitweb: the commitdiff is very commonly used, it's needed on search page, too

I'll queue this to my tree but will drop if I hear objections from gitweb people CC'ed over the weekend.

Jakub Narebski· Dec 1, 2007, 03:04 UTC · re: Junio C Hamano · lore

Re: [PATCH] gitweb: the commitdiff is very commonly used, it's needed on search page, too

Junio C Hamano wrote:

> I'll queue this to my tree but will drop if I hear objections from
> gitweb people CC'ed over the weekend.

This just ads link to 'search' view to 'commitdiff'; looks very nice.

Acked-by: Jakub Narebski <jnareb@gmail.com>

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git