{"thread":{"id":"11023","subject":"[PATCH] gitweb: the commitdiff is very commonly used, it's needed on search page, too","startedAt":"2007-11-26T12:42:06Z","lastAt":"2007-12-01T03:04:24Z","messageCount":3,"participants":["Denis Cheng","Junio C Hamano","Jakub Narebski"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"60930","messageId":"1196080926-5962-1-git-send-email-crquan@gmail.com","threadId":"11023","inReplyTo":null,"subject":"[PATCH] gitweb: the commitdiff is very commonly used, it's needed on search page, too","fromName":"Denis Cheng","fromEmail":"crquan@gmail.com","sentAt":"2007-11-26T12:42:06Z","receivedAt":"2007-11-26T12:42:06Z","isPatch":true,"sender":{"key":"crquan@gmail.com","avatar":"https://gravatar.com/avatar/8689a8a26f5d1c7515ca8226258710684dac5c5208b84a9e16a086377f2d3ded?d=mp&s=160"},"body":"---\n gitweb/gitweb.perl |    2 ++\n 1 files changed, 2 insertions(+), 0 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 491a3f4..ff5daa7 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -3786,6 +3786,8 @@ sub git_search_grep_body {\n \t\t      \"<td class=\\\"link\\\">\" .\n \t\t      $cgi->a({-href => href(action=>\"commit\", hash=>$co{'id'})}, \"commit\") .\n \t\t      \" | \" .\n+\t\t      $cgi->a({-href => href(action=>\"commitdiff\", hash=>$co{'id'})}, \"commitdiff\") .\n+\t\t      \" | \" .\n \t\t      $cgi->a({-href => href(action=>\"tree\", hash=>$co{'tree'}, hash_base=>$co{'id'})}, \"tree\");\n \t\tprint \"</td>\\n\" .\n \t\t      \"</tr>\\n\";\n-- \n1.5.3.4\n"},{"id":"61542","messageId":"7vwsrz9m5j.fsf@gitster.siamese.dyndns.org","threadId":"11023","inReplyTo":"1196080926-5962-1-git-send-email-crquan@gmail.com","subject":"Re: [PATCH] gitweb: the commitdiff is very commonly used, it's needed on search page, too","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-12-01T02:36:08Z","receivedAt":"2007-12-01T02:36:08Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"I'll queue this to my tree but will drop if I hear objections from\ngitweb people CC'ed over the weekend.\n"},{"id":"61554","messageId":"fiqivm$ose$1@ger.gmane.org","threadId":"11023","inReplyTo":"7vwsrz9m5j.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] gitweb: the commitdiff is very commonly used, it's needed on search page, too","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2007-12-01T03:04:24Z","receivedAt":"2007-12-01T03:04:24Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Junio C Hamano wrote:\n\n> I'll queue this to my tree but will drop if I hear objections from\n> gitweb people CC'ed over the weekend.\n\nThis just ads link to 'search' view to 'commitdiff'; looks very nice.\n\nAcked-by: Jakub Narebski <jnareb@gmail.com>\n\n-- \nJakub Narebski\nWarsaw, Poland\nShadeHawk on #git\n"}]}