# [PATCH] gitweb: the commitdiff is very commonly used, it's needed on search page, too

3 messages from 2007-11-26 to 2007-12-01. Participants: Denis Cheng, Junio C Hamano, Jakub Narebski.
Thread: https://gitlist.dev/t/11023

## Denis Cheng, 2007-11-26 12:42

Subject: [PATCH] gitweb: the commitdiff is very commonly used, it's needed on search page, too
Message-ID: <1196080926-5962-1-git-send-email-crquan@gmail.com>
URL: https://gitlist.dev/e/1196080926-5962-1-git-send-email-crquan%40gmail.com

```
---
 gitweb/gitweb.perl |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 491a3f4..ff5daa7 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -3786,6 +3786,8 @@ sub git_search_grep_body {
 		      "<td class=\"link\">" .
 		      $cgi->a({-href => href(action=>"commit", hash=>$co{'id'})}, "commit") .
 		      " | " .
+		      $cgi->a({-href => href(action=>"commitdiff", hash=>$co{'id'})}, "commitdiff") .
+		      " | " .
 		      $cgi->a({-href => href(action=>"tree", hash=>$co{'tree'}, hash_base=>$co{'id'})}, "tree");
 		print "</td>\n" .
 		      "</tr>\n";
-- 
1.5.3.4

```

## Junio C Hamano, 2007-12-01 02:36

Subject: Re: [PATCH] gitweb: the commitdiff is very commonly used, it's needed on search page, too
Message-ID: <7vwsrz9m5j.fsf@gitster.siamese.dyndns.org>
URL: https://gitlist.dev/e/7vwsrz9m5j.fsf%40gitster.siamese.dyndns.org
In-Reply-To: <1196080926-5962-1-git-send-email-crquan@gmail.com>

```
I'll queue this to my tree but will drop if I hear objections from
gitweb people CC'ed over the weekend.

```

## Jakub Narebski, 2007-12-01 03:04

Subject: Re: [PATCH] gitweb: the commitdiff is very commonly used, it's needed on search page, too
Message-ID: <fiqivm$ose$1@ger.gmane.org>
URL: https://gitlist.dev/e/fiqivm%24ose%241%40ger.gmane.org
In-Reply-To: <7vwsrz9m5j.fsf@gitster.siamese.dyndns.org>

```
Junio C Hamano wrote:

> I'll queue this to my tree but will drop if I hear objections from
> gitweb people CC'ed over the weekend.

This just ads link to 'search' view to 'commitdiff'; looks very nice.

Acked-by: Jakub Narebski <jnareb@gmail.com>

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git

```