threads / rfc / 10632

[RFC] OSX Mail.app IMAP cache support for git-mailsplit?

Subject: [RFC] OSX Mail.app IMAP cache support for git-mailsplit?

## tl;dr

4 messages between Nov 4, 2007 and Nov 5, 2007.

replies: 3people: 2as markdown or json

Michael J. Cohen· Nov 4, 2007, 05:49 UTC · lore

Trivially, adding support for checking for Messages/ inside the specified Maildir after cur/ is found not to exist would be enough to make this work.

Is there interest in a patch for this at all?
-mjc
Michael Cohen· Nov 5, 2007, 06:36 UTC · re: Michael J. Cohen · lore

[RFC PATCH] OSX Mail.app IMAP cache support for git-mailsplit?

On Nov 4, 2007, at 1:49 AM, Michael J. Cohen wrote:
> Trivially, adding support for checking for Messages/ inside the  
> specified Maildir after cur/ is found not to exist would be enough  
> to make this work.
my repo at git://home.325i.org/git-osxmail.git should have that portion.

unsure as to whether to make it an option, a fallback, a config value, or whatever...

-mjc
Johannes Schindelin· Nov 5, 2007, 10:39 UTC · re: Michael Cohen · lore

Re: [RFC PATCH] OSX Mail.app IMAP cache support for git-mailsplit?

Hi,

you have a very weird mail setting; I had to add the git list back to the Cc. This is just annoying enough for me to write an extra paragraph to annoy you back ;-)

On Mon, 5 Nov 2007, Michael Cohen wrote:
Show 9 quoted lines
> On Nov 4, 2007, at 1:49 AM, Michael J. Cohen wrote:
> 
> > Trivially, adding support for checking for Messages/ inside the specified
> > Maildir after cur/ is found not to exist would be enough to make this work.
> 
> my repo at git://home.325i.org/git-osxmail.git should have that portion.
> 
> unsure as to whether to make it an option, a fallback, a config value, or
> whatever...
A fallback would be sufficient.

Several comments (your patch not inlined, since you did not inline it either):

- there needs to be a space between the ) and the { in the first if line.
- you probably forgot to remove the original "if (populate...)...".  That 
  means that populate would be called _twice_, even if successful.
- git is written in C.  Therefore, "//" as a way to comment out is wrong.
- if you still return -1 when the dir could not be opened, I wonder what 
  the rationale is to comment the error out.

Ciao, Dscho

P.S.: You might want to send patches as these right away, without asking if anybody cares (you'll see that very soon), but rather in accord with Documentation/SubmittingPatches.

Michael Cohen· Nov 5, 2007, 12:09 UTC · re: Johannes Schindelin · lore

Re: [RFC PATCH] OSX Mail.app IMAP cache support for git-mailsplit?

On Nov 5, 2007, at 5:39 AM, Johannes Schindelin wrote:
Show 7 quoted lines
> Hi,
>
> you have a very weird mail setting; I had to add the git list back  
> to the
> Cc.  This is just annoying enough for me to write an extra paragraph  
> to
> annoy you back ;-)
Have to get used to this; thank you. :)
Show 5 quoted lines
> Several comments (your patch not inlined, since you did not inline it
> either):
>
> - there needs to be a space between the ) and the { in the first if  
> line.
Doh. done.
> - you probably forgot to remove the original "if (populate...)...".   
> That
>  means that populate would be called _twice_, even if successful.
good catch.
> - git is written in C.  Therefore, "//" as a way to comment out is  
> wrong.
> - if you still return -1 when the dir could not be opened, I wonder  
> what
>  the rationale is to comment the error out.

More work needs to be done in there and in builtin-mailinfo.c to massage the mail format that Apple is using. Also what I think I need to do there is check the path that is being tested and print something like "%s/cur could not be found, trying alternate path" on the first test?

Show 5 quoted lines
> P.S.: You might want to send patches as these right away, without  
> asking
> if anybody cares (you'll see that very soon), but rather in accord  
> with
> Documentation/SubmittingPatches.
Thanks for that.

← back to recent threads