Re: [RFC PATCH] OSX Mail.app IMAP cache support for git-mailsplit?

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 5, 2007, 10:39 UTC
Message-ID: <Pine.LNX.4.64.0711051034060.4362@racer.site>
In-Reply-To: <7B209F05-B720-41D6-AE98-39FAFF04B9F6@mac.com>

Hi,

you have a very weird mail setting; I had to add the git list back to the Cc. This is just annoying enough for me to write an extra paragraph to annoy you back ;-)

On Mon, 5 Nov 2007, Michael Cohen wrote:

Show 9 quoted lines

> On Nov 4, 2007, at 1:49 AM, Michael J. Cohen wrote:
> 
> > Trivially, adding support for checking for Messages/ inside the specified
> > Maildir after cur/ is found not to exist would be enough to make this work.
> 
> my repo at git://home.325i.org/git-osxmail.git should have that portion.
> 
> unsure as to whether to make it an option, a fallback, a config value, or
> whatever...

A fallback would be sufficient.

Several comments (your patch not inlined, since you did not inline it either):

- there needs to be a space between the ) and the { in the first if line.

- you probably forgot to remove the original "if (populate...)...".  That 
  means that populate would be called _twice_, even if successful.

- git is written in C.  Therefore, "//" as a way to comment out is wrong.

- if you still return -1 when the dir could not be opened, I wonder what 
  the rationale is to comment the error out.

Ciao, Dscho

P.S.: You might want to send patches as these right away, without asking if anybody cares (you'll see that very soon), but rather in accord with Documentation/SubmittingPatches.