{"thread":{"id":"10632","subject":"[RFC] OSX Mail.app IMAP cache support for git-mailsplit?","startedAt":"2007-11-04T05:49:32Z","lastAt":"2007-11-05T12:09:26Z","messageCount":4,"participants":["Michael J. Cohen","Michael Cohen","Johannes Schindelin"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"58218","messageId":"06FE21A2-20D0-4AAA-B0C7-35783C604B68@mac.com","threadId":"10632","inReplyTo":null,"subject":"[RFC] OSX Mail.app IMAP cache support for git-mailsplit?","fromName":"Michael J. Cohen","fromEmail":"michaeljosephcohen@mac.com","sentAt":"2007-11-04T05:49:32Z","receivedAt":"2007-11-04T05:49:32Z","isPatch":false,"sender":{"key":"michaeljosephcohen@mac.com","avatar":null},"body":"Trivially, adding support for checking for Messages/ inside the  \nspecified Maildir after cur/ is found not to exist would be enough to  \nmake this work.\n\nIs there interest in a patch for this at all?\n\n-mjc\n"},{"id":"58351","messageId":"7B209F05-B720-41D6-AE98-39FAFF04B9F6@mac.com","threadId":"10632","inReplyTo":"06FE21A2-20D0-4AAA-B0C7-35783C604B68@mac.com","subject":"[RFC PATCH] OSX Mail.app IMAP cache support for git-mailsplit?","fromName":"Michael Cohen","fromEmail":"michaeljosephcohen@mac.com","sentAt":"2007-11-05T06:36:11Z","receivedAt":"2007-11-05T06:36:11Z","isPatch":true,"sender":{"key":"michaeljosephcohen@mac.com","avatar":null},"body":"On Nov 4, 2007, at 1:49 AM, Michael J. Cohen wrote:\n\n> Trivially, adding support for checking for Messages/ inside the  \n> specified Maildir after cur/ is found not to exist would be enough  \n> to make this work.\n\nmy repo at git://home.325i.org/git-osxmail.git should have that portion.\n\nunsure as to whether to make it an option, a fallback, a config value,  \nor whatever...\n\n-mjc\n"},{"id":"58358","messageId":"Pine.LNX.4.64.0711051034060.4362@racer.site","threadId":"10632","inReplyTo":"7B209F05-B720-41D6-AE98-39FAFF04B9F6@mac.com","subject":"Re: [RFC PATCH] OSX Mail.app IMAP cache support for git-mailsplit?","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-11-05T10:39:27Z","receivedAt":"2007-11-05T10:39:27Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi,\n\nyou have a very weird mail setting; I had to add the git list back to the \nCc.  This is just annoying enough for me to write an extra paragraph to \nannoy you back ;-)\n\nOn Mon, 5 Nov 2007, Michael Cohen wrote:\n\n> On Nov 4, 2007, at 1:49 AM, Michael J. Cohen wrote:\n> \n> > Trivially, adding support for checking for Messages/ inside the specified\n> > Maildir after cur/ is found not to exist would be enough to make this work.\n> \n> my repo at git://home.325i.org/git-osxmail.git should have that portion.\n> \n> unsure as to whether to make it an option, a fallback, a config value, or\n> whatever...\n\nA fallback would be sufficient.\n\nSeveral comments (your patch not inlined, since you did not inline it \neither):\n\n- there needs to be a space between the ) and the { in the first if line.\n\n- you probably forgot to remove the original \"if (populate...)...\".  That \n  means that populate would be called _twice_, even if successful.\n\n- git is written in C.  Therefore, \"//\" as a way to comment out is wrong.\n\n- if you still return -1 when the dir could not be opened, I wonder what \n  the rationale is to comment the error out.\n\nCiao,\nDscho\n\nP.S.: You might want to send patches as these right away, without asking \nif anybody cares (you'll see that very soon), but rather in accord with \nDocumentation/SubmittingPatches.\n"},{"id":"58365","messageId":"7B84FFB7-5FE9-4D24-AEC5-43F667B59876@mac.com","threadId":"10632","inReplyTo":"Pine.LNX.4.64.0711051034060.4362@racer.site","subject":"Re: [RFC PATCH] OSX Mail.app IMAP cache support for git-mailsplit?","fromName":"Michael Cohen","fromEmail":"michaeljosephcohen@mac.com","sentAt":"2007-11-05T12:09:26Z","receivedAt":"2007-11-05T12:09:26Z","isPatch":true,"sender":{"key":"michaeljosephcohen@mac.com","avatar":null},"body":"On Nov 5, 2007, at 5:39 AM, Johannes Schindelin wrote:\n\n> Hi,\n>\n> you have a very weird mail setting; I had to add the git list back  \n> to the\n> Cc.  This is just annoying enough for me to write an extra paragraph  \n> to\n> annoy you back ;-)\nHave to get used to this; thank you. :)\n\n> Several comments (your patch not inlined, since you did not inline it\n> either):\n>\n> - there needs to be a space between the ) and the { in the first if  \n> line.\nDoh. done.\n\n> - you probably forgot to remove the original \"if (populate...)...\".   \n> That\n>  means that populate would be called _twice_, even if successful.\n\ngood catch.\n\n> - git is written in C.  Therefore, \"//\" as a way to comment out is  \n> wrong.\n\n> - if you still return -1 when the dir could not be opened, I wonder  \n> what\n>  the rationale is to comment the error out.\n\nMore work needs to be done in there and in builtin-mailinfo.c to  \nmassage the mail format that Apple is using.  Also what I think I need  \nto do there is check the path that is being tested and print something  \nlike \"%s/cur could not be found, trying alternate path\" on the first  \ntest?\n\n\n> P.S.: You might want to send patches as these right away, without  \n> asking\n> if anybody cares (you'll see that very soon), but rather in accord  \n> with\n> Documentation/SubmittingPatches.\n\nThanks for that. \n  \n"}]}