threads / patch / 10590

patchRe: [PATCH] Make git-clone obey "--" (end argument parsing)

Subject: Re: [PATCH] Make git-clone obey "--" (end argument parsing)

## tl;dr

2 messages between Nov 2, 2007 and Nov 2, 2007. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Heikki Orsila· Nov 2, 2007, 14:21 UTC · lore

Junio C Hamano wrote:

> I do not think this breaks anything, but does it _help_
> anything in practice?
> 
> What kind of breakage does this patch fix?

It doesn't fix anything, but it is a good usability standard to obey --. I was creating a script that would _automatically_ clone repositories of other users. As a little bit pedantic shell script writer I added "--" and noticed that git clone doesn't handle that, although it's expected behavior from many tools.

-- 
Heikki Orsila			Barbie's law:
heikki.orsila@iki.fi		"Math is hard, let's go shopping!"
http://www.iki.fi/shd

Junio C Hamano· Nov 2, 2007, 21:32 UTC · re: Heikki Orsila · lore

Heikki Orsila <shd@modeemi.fi> writes:

Show 10 quoted lines

> Junio C Hamano wrote:
>> I do not think this breaks anything, but does it _help_
>> anything in practice?
>> 
>> What kind of breakage does this patch fix?
>
> It doesn't fix anything, but it is a good usability standard to obey --.
> I was creating a script that would _automatically_ clone repositories of 
> other users. As a little bit pedantic shell script writer I added "--" 
> and noticed that git clone doesn't handle that,...

The first real parameter will always be the remote repo URL^Wlocator, and sane people won't have anything that begin with a hyphen for that, will they?

So the change is only for consistency's sake.

I am not saying that is a bad thing. I just wanted to understand if there was a real breakage there.

Thanks. Will apply.