Re: [PATCH] Make git-clone obey "--" (end argument parsing)
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 2, 2007, 21:32 UTC
- Message-ID
- <7vwst0z63o.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <20071102142150.GD9632@jolt.modeemi.cs.tut.fi>
Heikki Orsila <shd@modeemi.fi> writes:
Show 10 quoted lines
> Junio C Hamano wrote: >> I do not think this breaks anything, but does it _help_ >> anything in practice? >> >> What kind of breakage does this patch fix? > > It doesn't fix anything, but it is a good usability standard to obey --. > I was creating a script that would _automatically_ clone repositories of > other users. As a little bit pedantic shell script writer I added "--" > and noticed that git clone doesn't handle that,...
The first real parameter will always be the remote repo URL^Wlocator, and sane people won't have anything that begin with a hyphen for that, will they?
So the change is only for consistency's sake.
I am not saying that is a bad thing. I just wanted to understand if there was a real breakage there.
Thanks. Will apply.