# Re: [PATCH] Make git-clone obey "--" (end argument parsing)

2 messages from 2007-11-02 to 2007-11-02. Participants: Heikki Orsila, Junio C Hamano.
Thread: https://gitlist.dev/t/10590

## Heikki Orsila, 2007-11-02 14:21

Subject: Re: [PATCH] Make git-clone obey "--" (end argument parsing)
Message-ID: <20071102142150.GD9632@jolt.modeemi.cs.tut.fi>
URL: https://gitlist.dev/e/20071102142150.GD9632%40jolt.modeemi.cs.tut.fi

```
Junio C Hamano wrote:
> I do not think this breaks anything, but does it _help_
> anything in practice?
> 
> What kind of breakage does this patch fix?

It doesn't fix anything, but it is a good usability standard to obey --.
I was creating a script that would _automatically_ clone repositories of 
other users. As a little bit pedantic shell script writer I added "--" 
and noticed that git clone doesn't handle that, although it's expected 
behavior from many tools.

-- 
Heikki Orsila			Barbie's law:
heikki.orsila@iki.fi		"Math is hard, let's go shopping!"
http://www.iki.fi/shd

```

## Junio C Hamano, 2007-11-02 21:32

Subject: Re: [PATCH] Make git-clone obey "--" (end argument parsing)
Message-ID: <7vwst0z63o.fsf@gitster.siamese.dyndns.org>
URL: https://gitlist.dev/e/7vwst0z63o.fsf%40gitster.siamese.dyndns.org
In-Reply-To: <20071102142150.GD9632@jolt.modeemi.cs.tut.fi>

```
Heikki Orsila <shd@modeemi.fi> writes:

> Junio C Hamano wrote:
>> I do not think this breaks anything, but does it _help_
>> anything in practice?
>> 
>> What kind of breakage does this patch fix?
>
> It doesn't fix anything, but it is a good usability standard to obey --.
> I was creating a script that would _automatically_ clone repositories of 
> other users. As a little bit pedantic shell script writer I added "--" 
> and noticed that git clone doesn't handle that,...

The first real parameter will always be the remote repo
URL^Wlocator, and sane people won't have anything that begin
with a hyphen for that, will they?

So the change is only for consistency's sake.

I am not saying that is a bad thing.  I just wanted to
understand if there was a real breakage there.

Thanks. Will apply.

```