threads / patch / 10433

patchRe: [PATCH] use only the PATH for exec'ing git commands

Subject: Re: [PATCH] use only the PATH for exec'ing git commands

## tl;dr

2 messages between Oct 22, 2007 and Oct 22, 2007. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Scott R Parish· Oct 22, 2007, 19:59 UTC · lore

Show 5 quoted lines

> Alex Reisen, Mon, Oct 22, 2007 12:01:
> > +                strbuf_addch(out, ':');
>
> Shouldn't it break MingW32 native port?
>

<snip>

> > +        if (old_path)
> > +                strbuf_addstr(&amp;new_path, old_path);
> > +        else
> > +                strbuf_addstr(&amp;new_path,

"/usr/local/bin:/usr/bin:/bin");

Show 5 quoted lines

>
> the default PATH is platform-dependent. Git is multi-platform.
> You should consider putting the path list somewhere in Makefile,
> config.mak or configure.
>

The original code was already doing both of these things (see git.c's prepend_to_path())

sRp

Alex Riesen· Oct 22, 2007, 20:57 UTC · re: Scott R Parish · lore

Scott R Parish, Mon, Oct 22, 2007 21:59:01 +0200:

Show 12 quoted lines

> > > +        if (old_path)
> > > +                strbuf_addstr(&amp;new_path, old_path);
> > > +        else
> > > +                strbuf_addstr(&amp;new_path, "/usr/local/bin:/usr/bin:/bin");
> >
> > the default PATH is platform-dependent. Git is multi-platform.
> > You should consider putting the path list somewhere in Makefile,
> > config.mak or configure.
> >
> 
> The original code was already doing both of these things (see git.c's
> prepend_to_path())

Well, would be nice if your code was better in this respect.

Anyway, I suspect the mingw people will trash the code anyway sometime (or not, which is just as well - it is a rare case).