{"thread":{"id":"10433","subject":"Re: [PATCH] use only the PATH for exec'ing git commands","startedAt":"2007-10-22T19:59:01Z","lastAt":"2007-10-22T20:57:37Z","messageCount":2,"participants":["Scott R Parish","Alex Riesen"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"56911","messageId":"1193083141.v2.fusewebmail-240137@f","threadId":"10433","inReplyTo":null,"subject":"Re: [PATCH] use only the PATH for exec'ing git commands","fromName":"Scott R Parish","fromEmail":"srp@srparish.net","sentAt":"2007-10-22T19:59:01Z","receivedAt":"2007-10-22T19:59:01Z","isPatch":true,"sender":{"key":"srp@srparish.net","avatar":"https://gravatar.com/avatar/870e5b6fc4f710cf4db5684bd9af7f2cee5734b3dab3209b13e00cf64f6c9f0e?d=mp&s=160"},"body":"\n> Alex Reisen, Mon, Oct 22, 2007 12:01:\n> > +                strbuf_addch(out, ':');\n>\n> Shouldn't it break MingW32 native port?\n>\n\n<snip>\n\n> > +        if (old_path)\n> > +                strbuf_addstr(&amp;new_path, old_path);\n> > +        else\n> > +                strbuf_addstr(&amp;new_path,\n\"/usr/local/bin:/usr/bin:/bin\");\n>\n> the default PATH is platform-dependent. Git is multi-platform.\n> You should consider putting the path list somewhere in Makefile,\n> config.mak or configure.\n>\n\nThe original code was already doing both of these things (see git.c's\nprepend_to_path())\n\nsRp\n"},{"id":"56915","messageId":"20071022205737.GC23714@steel.home","threadId":"10433","inReplyTo":"1193083141.v2.fusewebmail-240137@f","subject":"Re: [PATCH] use only the PATH for exec'ing git commands","fromName":"Alex Riesen","fromEmail":"raa.lkml@gmail.com","sentAt":"2007-10-22T20:57:37Z","receivedAt":"2007-10-22T20:57:37Z","isPatch":true,"sender":{"key":"raa.lkml@gmail.com","avatar":"https://avatars.githubusercontent.com/u/324101?v=4"},"body":"Scott R Parish, Mon, Oct 22, 2007 21:59:01 +0200:\n> > > +        if (old_path)\n> > > +                strbuf_addstr(&amp;new_path, old_path);\n> > > +        else\n> > > +                strbuf_addstr(&amp;new_path, \"/usr/local/bin:/usr/bin:/bin\");\n> >\n> > the default PATH is platform-dependent. Git is multi-platform.\n> > You should consider putting the path list somewhere in Makefile,\n> > config.mak or configure.\n> >\n> \n> The original code was already doing both of these things (see git.c's\n> prepend_to_path())\n\nWell, would be nice if your code was better in this respect.\n\nAnyway, I suspect the mingw people will trash the code anyway sometime\n(or not, which is just as well - it is a rare case).\n"}]}