Re: [PATCH] use only the PATH for exec'ing git commands

From: Alex Riesen <raa.lkml@gmail.com>
Date: Oct 22, 2007, 20:57 UTC
Message-ID: <20071022205737.GC23714@steel.home>
In-Reply-To: <1193083141.v2.fusewebmail-240137@f>

Scott R Parish, Mon, Oct 22, 2007 21:59:01 +0200:

Show 12 quoted lines

> > > +        if (old_path)
> > > +                strbuf_addstr(&amp;new_path, old_path);
> > > +        else
> > > +                strbuf_addstr(&amp;new_path, "/usr/local/bin:/usr/bin:/bin");
> >
> > the default PATH is platform-dependent. Git is multi-platform.
> > You should consider putting the path list somewhere in Makefile,
> > config.mak or configure.
> >
> 
> The original code was already doing both of these things (see git.c's
> prepend_to_path())

Well, would be nice if your code was better in this respect.

Anyway, I suspect the mingw people will trash the code anyway sometime (or not, which is just as well - it is a rare case).