threads / patch / 10295

patchcvsexportcommit: get rid of temporary directory

Subject: [PATCH] cvsexportcommit: get rid of temporary directory

## tl;dr

2 messages between Oct 15, 2007 and Oct 16, 2007. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Johannes Schindelin· Oct 15, 2007, 22:32 UTC · lore

Since commit e86ad71fe5f53ae4434566bd09ea4256090e5a3a we do not use a temporary directory in cvsexportcommit. So there is no need to set one up.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 git-cvsexportcommit.perl |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

Show changes to git-cvsexportcommit.perl +0 −5

diff --git a/git-cvsexportcommit.perl b/git-cvsexportcommit.perl
index a33fa8d..6b0123c 100755
--- a/git-cvsexportcommit.perl
+++ b/git-cvsexportcommit.perl
@@ -30,11 +30,6 @@ if ($opt_d) {
 	@cvs = ('cvs');
 }
 
-# setup a tempdir
-our ($tmpdir, $tmpdirname) = tempdir('git-cvsapplycommit-XXXXXX',
-				     TMPDIR => 1,
-				     CLEANUP => 1);
-
 # resolve target commit
 my $commit;
 $commit = pop @ARGV;

-- 
1.5.3.4.1174.gcd0d6-dirty

Robin Rosenberg· Oct 16, 2007, 21:22 UTC · re: Johannes Schindelin · lore

Re: [PATCH] cvsexportcommit: get rid of temporary directory

tisdag 16 oktober 2007 skrev Johannes Schindelin:

Show 6 quoted lines

> 
> Since commit e86ad71fe5f53ae4434566bd09ea4256090e5a3a we do not use
> a temporary directory in cvsexportcommit.  So there is no need to set
> one up.
> 
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

Acked

Discovered because Wingit made a lot of noise about $tmpdir being used only once.

-- robin