# [PATCH] cvsexportcommit: get rid of temporary directory

2 messages from 2007-10-15 to 2007-10-16. Participants: Johannes Schindelin, Robin Rosenberg.
Thread: https://gitlist.dev/t/10295

## Johannes Schindelin, 2007-10-15 22:32

Subject: [PATCH] cvsexportcommit: get rid of temporary directory
Message-ID: <Pine.LNX.4.64.0710152332230.25221@racer.site>
URL: https://gitlist.dev/e/Pine.LNX.4.64.0710152332230.25221%40racer.site

```

Since commit e86ad71fe5f53ae4434566bd09ea4256090e5a3a we do not use
a temporary directory in cvsexportcommit.  So there is no need to set
one up.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 git-cvsexportcommit.perl |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/git-cvsexportcommit.perl b/git-cvsexportcommit.perl
index a33fa8d..6b0123c 100755
--- a/git-cvsexportcommit.perl
+++ b/git-cvsexportcommit.perl
@@ -30,11 +30,6 @@ if ($opt_d) {
 	@cvs = ('cvs');
 }
 
-# setup a tempdir
-our ($tmpdir, $tmpdirname) = tempdir('git-cvsapplycommit-XXXXXX',
-				     TMPDIR => 1,
-				     CLEANUP => 1);
-
 # resolve target commit
 my $commit;
 $commit = pop @ARGV;
-- 
1.5.3.4.1174.gcd0d6-dirty

```

## Robin Rosenberg, 2007-10-16 21:22

Subject: Re: [PATCH] cvsexportcommit: get rid of temporary directory
Message-ID: <200710162322.47324.robin.rosenberg.lists@dewire.com>
URL: https://gitlist.dev/e/200710162322.47324.robin.rosenberg.lists%40dewire.com
In-Reply-To: <Pine.LNX.4.64.0710152332230.25221@racer.site>

```
tisdag 16 oktober 2007 skrev Johannes Schindelin:
> 
> Since commit e86ad71fe5f53ae4434566bd09ea4256090e5a3a we do not use
> a temporary directory in cvsexportcommit.  So there is no need to set
> one up.
> 
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Acked

Discovered because Wingit made a lot of noise about $tmpdir being used only
once. 

-- robin

```