{"thread":{"id":"10295","subject":"[PATCH] cvsexportcommit: get rid of temporary directory","startedAt":"2007-10-15T22:32:45Z","lastAt":"2007-10-16T21:22:47Z","messageCount":2,"participants":["Johannes Schindelin","Robin Rosenberg"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"55918","messageId":"Pine.LNX.4.64.0710152332230.25221@racer.site","threadId":"10295","inReplyTo":null,"subject":"[PATCH] cvsexportcommit: get rid of temporary directory","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2007-10-15T22:32:45Z","receivedAt":"2007-10-15T22:32:45Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"\nSince commit e86ad71fe5f53ae4434566bd09ea4256090e5a3a we do not use\na temporary directory in cvsexportcommit.  So there is no need to set\none up.\n\nSigned-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>\n---\n git-cvsexportcommit.perl |    5 -----\n 1 files changed, 0 insertions(+), 5 deletions(-)\n\ndiff --git a/git-cvsexportcommit.perl b/git-cvsexportcommit.perl\nindex a33fa8d..6b0123c 100755\n--- a/git-cvsexportcommit.perl\n+++ b/git-cvsexportcommit.perl\n@@ -30,11 +30,6 @@ if ($opt_d) {\n \t@cvs = ('cvs');\n }\n \n-# setup a tempdir\n-our ($tmpdir, $tmpdirname) = tempdir('git-cvsapplycommit-XXXXXX',\n-\t\t\t\t     TMPDIR => 1,\n-\t\t\t\t     CLEANUP => 1);\n-\n # resolve target commit\n my $commit;\n $commit = pop @ARGV;\n-- \n1.5.3.4.1174.gcd0d6-dirty\n"},{"id":"56126","messageId":"200710162322.47324.robin.rosenberg.lists@dewire.com","threadId":"10295","inReplyTo":"Pine.LNX.4.64.0710152332230.25221@racer.site","subject":"Re: [PATCH] cvsexportcommit: get rid of temporary directory","fromName":"Robin Rosenberg","fromEmail":"robin.rosenberg.lists@dewire.com","sentAt":"2007-10-16T21:22:47Z","receivedAt":"2007-10-16T21:22:47Z","isPatch":true,"sender":{"key":"robin.rosenberg@dewire.com","avatar":"https://avatars.githubusercontent.com/u/46357?v=4"},"body":"tisdag 16 oktober 2007 skrev Johannes Schindelin:\n> \n> Since commit e86ad71fe5f53ae4434566bd09ea4256090e5a3a we do not use\n> a temporary directory in cvsexportcommit.  So there is no need to set\n> one up.\n> \n> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>\nAcked\n\nDiscovered because Wingit made a lot of noise about $tmpdir being used only\nonce. \n\n-- robin\n"}]}