[PATCH] gitk: use git log --no-color vs. "diff.color = true"

Michele Ballabio· Oct 10, 2007, 08:58 UTC · lore

Setting "diff.color = true" in the configuration makes "git log" output use color codes. These aren't parsed by gitk, so use "git log --no-color" instead.

Signed-off-by: Michele Ballabio <barra_cuda@katamail.com>
---

Yes, this is the same fix that commit eeebd8d8c5ab63494abe200b30a840aa99ee7412 applied on git-svn.

 gitk |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to gitk +1 −1

diff --git a/gitk b/gitk
index 300fdce..999e3c2 100755
--- a/gitk
+++ b/gitk
@@ -92,7 +92,7 @@ proc start_rev_list {view} {
 	set order "--date-order"
     }
     if {[catch {
-	set fd [open [concat | git log -z --pretty=raw $order --parents \
+	set fd [open [concat | git log --no-color -z --pretty=raw $order --parents \
 			 --boundary $viewargs($view) "--" $viewfiles($view)] r]
     } err]} {
 	error_popup "Error executing git rev-list: $err"

-- 
1.5.3.4

patchgitk: use git log --no-color vs. "diff.color = true"