{"thread":{"id":"10227","subject":"[PATCH] gitk: use git log --no-color vs. \"diff.color = true\"","startedAt":"2007-10-10T08:58:30Z","lastAt":"2007-10-10T08:58:30Z","messageCount":1,"participants":["Michele Ballabio"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"55354","messageId":"200710101058.30911.barra_cuda@katamail.com","threadId":"10227","inReplyTo":null,"subject":"[PATCH] gitk: use git log --no-color vs. \"diff.color = true\"","fromName":"Michele Ballabio","fromEmail":"barra_cuda@katamail.com","sentAt":"2007-10-10T08:58:30Z","receivedAt":"2007-10-10T08:58:30Z","isPatch":true,"sender":{"key":"barra_cuda@katamail.com","avatar":"https://avatars.githubusercontent.com/u/16371673?v=4"},"body":"Setting \"diff.color = true\" in the configuration makes \"git log\"\noutput use color codes. These aren't parsed by gitk, so use\n\"git log --no-color\" instead.\n\nSigned-off-by: Michele Ballabio <barra_cuda@katamail.com>\n---\n\nYes, this is the same fix that commit eeebd8d8c5ab63494abe200b30a840aa99ee7412\napplied on git-svn.\n\n gitk |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/gitk b/gitk\nindex 300fdce..999e3c2 100755\n--- a/gitk\n+++ b/gitk\n@@ -92,7 +92,7 @@ proc start_rev_list {view} {\n \tset order \"--date-order\"\n     }\n     if {[catch {\n-\tset fd [open [concat | git log -z --pretty=raw $order --parents \\\n+\tset fd [open [concat | git log --no-color -z --pretty=raw $order --parents \\\n \t\t\t --boundary $viewargs($view) \"--\" $viewfiles($view)] r]\n     } err]} {\n \terror_popup \"Error executing git rev-list: $err\"\n-- \n1.5.3.4\n"}]}