git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] gitk: use git log --no-color vs. "diff.color = true"

From
Michele Ballabio <barra_cuda@katamail.com>
Date
Oct 10, 2007, 08:58 UTC
Message-ID
<200710101058.30911.barra_cuda@katamail.com>

Setting "diff.color = true" in the configuration makes "git log" output use color codes. These aren't parsed by gitk, so use "git log --no-color" instead.

Signed-off-by: Michele Ballabio <barra_cuda@katamail.com>
---

Yes, this is the same fix that commit eeebd8d8c5ab63494abe200b30a840aa99ee7412 applied on git-svn.

 gitk |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gitk b/gitk
index 300fdce..999e3c2 100755
--- a/gitk
+++ b/gitk
@@ -92,7 +92,7 @@ proc start_rev_list {view} {
 	set order "--date-order"
     }
     if {[catch {
-	set fd [open [concat | git log -z --pretty=raw $order --parents \
+	set fd [open [concat | git log --no-color -z --pretty=raw $order --parents \
 			 --boundary $viewargs($view) "--" $viewfiles($view)] r]
     } err]} {
 	error_popup "Error executing git rev-list: $err"
-- 
1.5.3.4
Message 1 of 1 in “gitk: use git log --no-color vs. "diff.color = true"”
  1. gitk: use git log --no-color vs. "diff.color = true"Michele Ballabio, Oct 10, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.