threads / patch / 10067

patchgitk: add check for required tcl version >= 8.4

Subject: [PATCH] gitk: add check for required tcl version >= 8.4

## tl;dr

2 messages between Sep 29, 2007 and Oct 20, 2007. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Junio C Hamano· Sep 29, 2007, 09:32 UTC · lore

From: Steffen Prohaska <prohaska@zib.de>
Date: Fri, 28 Sep 2007 22:57:22 +0200

gitk requires tcl version >= 8.4 to work flawlessly. So let's check the tcl version and quit if it's too low.

Signed-off-by: Steffen Prohaska <prohaska@zib.de>
---

 * I do not have a ready access to older tcl/tk myself, so I
   cannot judge if this is sensible or not.  Just forwarding in
   case you missed it.

 gitk |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

Show changes to gitk +5 −0

diff --git a/gitk b/gitk
index 300fdce..6ea6489 100755
--- a/gitk
+++ b/gitk
@@ -7,6 +7,11 @@ exec wish "$0" -- "$@"
 # and distributed under the terms of the GNU General Public Licence,
 # either version 2, or (at your option) any later version.
 
+if {[info tclversion] < 8.4} {
+   puts stderr "Sorry, gitk requires tcl version >= 8.4."
+   exit 1 
+}
+
 proc gitdir {} {
     global env
     if {[info exists env(GIT_DIR)]} {

-- 
1.5.3.2.111.g5166

Paul Mackerras· Oct 20, 2007, 11:19 UTC · re: Junio C Hamano · lore

Re: [PATCH] gitk: add check for required tcl version >= 8.4

Junio C Hamano writes:

Show 12 quoted lines

> From: Steffen Prohaska <prohaska@zib.de>
> Date: Fri, 28 Sep 2007 22:57:22 +0200
> 
> gitk requires tcl version >= 8.4 to work flawlessly. So let's
> check the tcl version and quit if it's too low.
> 
> Signed-off-by: Steffen Prohaska <prohaska@zib.de>
> ---
> 
>  * I do not have a ready access to older tcl/tk myself, so I
>    cannot judge if this is sensible or not.  Just forwarding in
>    case you missed it.

Thanks for the patch. I have put in something similar using the package require command, and using show_error to display the error in a window.

Paul.