{"thread":{"id":"10067","subject":"[PATCH] gitk: add check for required tcl version >= 8.4","startedAt":"2007-09-29T09:32:54Z","lastAt":"2007-10-20T11:19:11Z","messageCount":2,"participants":["Junio C Hamano","Paul Mackerras"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"54321","messageId":"7vlkaplsu1.fsf@gitster.siamese.dyndns.org","threadId":"10067","inReplyTo":null,"subject":"[PATCH] gitk: add check for required tcl version >= 8.4","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2007-09-29T09:32:54Z","receivedAt":"2007-09-29T09:32:54Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"From: Steffen Prohaska <prohaska@zib.de>\nDate: Fri, 28 Sep 2007 22:57:22 +0200\n\ngitk requires tcl version >= 8.4 to work flawlessly. So let's\ncheck the tcl version and quit if it's too low.\n\nSigned-off-by: Steffen Prohaska <prohaska@zib.de>\n---\n\n * I do not have a ready access to older tcl/tk myself, so I\n   cannot judge if this is sensible or not.  Just forwarding in\n   case you missed it.\n\n gitk |    5 +++++\n 1 files changed, 5 insertions(+), 0 deletions(-)\n\ndiff --git a/gitk b/gitk\nindex 300fdce..6ea6489 100755\n--- a/gitk\n+++ b/gitk\n@@ -7,6 +7,11 @@ exec wish \"$0\" -- \"$@\"\n # and distributed under the terms of the GNU General Public Licence,\n # either version 2, or (at your option) any later version.\n \n+if {[info tclversion] < 8.4} {\n+   puts stderr \"Sorry, gitk requires tcl version >= 8.4.\"\n+   exit 1 \n+}\n+\n proc gitdir {} {\n     global env\n     if {[info exists env(GIT_DIR)]} {\n-- \n1.5.3.2.111.g5166\n"},{"id":"56688","messageId":"18201.58415.361214.601377@cargo.ozlabs.ibm.com","threadId":"10067","inReplyTo":"7vlkaplsu1.fsf@gitster.siamese.dyndns.org","subject":"Re: [PATCH] gitk: add check for required tcl version >= 8.4","fromName":"Paul Mackerras","fromEmail":"paulus@samba.org","sentAt":"2007-10-20T11:19:11Z","receivedAt":"2007-10-20T11:19:11Z","isPatch":true,"sender":{"key":"paulus@samba.org","avatar":"https://avatars.githubusercontent.com/u/1606439?v=4"},"body":"Junio C Hamano writes:\n\n> From: Steffen Prohaska <prohaska@zib.de>\n> Date: Fri, 28 Sep 2007 22:57:22 +0200\n> \n> gitk requires tcl version >= 8.4 to work flawlessly. So let's\n> check the tcl version and quit if it's too low.\n> \n> Signed-off-by: Steffen Prohaska <prohaska@zib.de>\n> ---\n> \n>  * I do not have a ready access to older tcl/tk myself, so I\n>    cannot judge if this is sensible or not.  Just forwarding in\n>    case you missed it.\n\nThanks for the patch.  I have put in something similar using the\npackage require command, and using show_error to display the error in\na window.\n\nPaul.\n"}]}