Re: [PATCH] gitk: add check for required tcl version >= 8.4
- From
Paul Mackerras <paulus@samba.org>
- Date
- Oct 20, 2007, 11:19 UTC
- Message-ID
- <18201.58415.361214.601377@cargo.ozlabs.ibm.com>
- In-Reply-To
- <7vlkaplsu1.fsf@gitster.siamese.dyndns.org>
Junio C Hamano writes:
Show 12 quoted lines
> From: Steffen Prohaska <prohaska@zib.de> > Date: Fri, 28 Sep 2007 22:57:22 +0200 > > gitk requires tcl version >= 8.4 to work flawlessly. So let's > check the tcl version and quit if it's too low. > > Signed-off-by: Steffen Prohaska <prohaska@zib.de> > --- > > * I do not have a ready access to older tcl/tk myself, so I > cannot judge if this is sensible or not. Just forwarding in > case you missed it.
Thanks for the patch. I have put in something similar using the package require command, and using show_error to display the error in a window.
Paul.