Hamano's patch adds a note to environment.h that the structure is frozen. His reasoning is that repo_config_values() cannot work on any repository instance other than the_repository, so moving more members into the structure is unwelcome.

He sent the patch again for wider visibility. Patrick Steinhardt acked it. Derrick Stolee gave his +1. He said the structure has grown organically and needs a redesign from first principles to avoid making the situation worse.

No opposing views appear in the excerpts, and no replacement design is proposed.