Steinhardt says the series cleans up the interfaces for writing commit graphs. Most importantly, all options now pass through struct commit_graph_write_options. The cleanups are split out of a bigger change to make reading and writing commit graphs pluggable via the object database backend.

The patches include renaming struct commit_graph_opts, passing writer flags via options, and renaming functions to the <subsystem>_<verb> scheme. Another patch moves commit-graph verification out of git-fsck's downcast to the files backend and into odb_source_files_fsck(), so verification can become pluggable. A further patch drops the separate flags in struct opts_commit_graph in favor of OPT_BIT().

Junio C Hamano said the remaining code became much easier to follow and wrote "Nicely done." Derrick Stolee said the first four patches were immediately obviously correct, called others "so much cleaner" and said one needed more work but is a valuable simplification. He gave an LGTM.

Kristofer Karlsson noted that the change touches his earlier patch cef2d8c4cb (fetch: write commit-graph using updated refs only). His only nit was that the if/else in fetch also covers the skip case. He suggested a switch over graph_write_mode so each mode sets only what it needs, and called it a preference with no effect on correctness.