Re: [PATCH] diff: add a 'path' meta header for non-renames and non-copies

From: Bert Wesarg <bert.wesarg@googlemail.com>
Date: May 3, 2010, 07:37 UTC
Message-ID: <z2m36ca99e91005030037jb880e65w73efa551a53d7be6@mail.gmail.com>
In-Reply-To: <7viq75tpaw.fsf@alter.siamese.dyndns.org>

On Mon, May 3, 2010 at 09:30, Junio C Hamano <gitster@pobox.com> wrote:

Show 10 quoted lines

> Sorry, but none of these configuration variables are acceptable as-is.
>
> Many scripts (the ones shipped with core-git, in contrib, or written by
> users) depend on their invocation of "git diff-*" family without any funny
> command line arguments like --no-prefix nor --src-prefix to produce a
> patch that can be applied without giving a custom -p value to "git apply".
>
> Letting the user break that promise is already bad, and not giving the
> scripts any way to protect themselves from these configuration variables
> by overriding from the command line makes these doubly bad ideas.

As far as I understand git_diff_ui_config() applies only for "git diff" not for any of the plumping "git diff-*" tools. Also I thought that these extended headers are exactly there to support arbitrary meta information. Therefore I think your arguments don't hold for my 'path' extended header, do they?

Thanks, Bert