git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] diff: add a 'path' meta header for non-renames and non-copies

From
Junio C Hamano <gitster@pobox.com>
Date
May 3, 2010, 07:30 UTC
Message-ID
<7viq75tpaw.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1272868072-12120-1-git-send-email-bert.wesarg@googlemail.com>
Sorry, but none of these configuration variables are acceptable as-is.

Many scripts (the ones shipped with core-git, in contrib, or written by users) depend on their invocation of "git diff-*" family without any funny command line arguments like --no-prefix nor --src-prefix to produce a patch that can be applied without giving a custom -p value to "git apply".

Letting the user break that promise is already bad, and not giving the scripts any way to protect themselves from these configuration variables by overriding from the command line makes these doubly bad ideas.

Previous: Bert WesargNext: Bert Wesarg
Message 3 of 9 in “diff: add configuration option for disabling diff prefixes.”
  1. diff: add configuration option for disabling diff prefixes.Eli Collins, May 3, 2010
  2. diff: add a 'path' meta header for non-renames and non-copiesBert Wesarg, May 3, 2010
  3. Junio C HamanoMay 3, 2010
  4. Bert WesargMay 3, 2010
  5. Junio C HamanoMay 3, 2010
  6. Bert WesargMay 3, 2010
  7. Junio C HamanoMay 4, 2010
  8. Bert WesargMay 4, 2010
  9. Eli CollinsMay 5, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.