Re: [PATCH] filter-branch: Grok special characters in tag names

From: Brandon Casey <casey@nrlssc.navy.mil>
Date: Aug 21, 2008, 21:34 UTC
Message-ID: <yncKq2pMiBaRiN-VbWFQsKLk4CfOXCHjFSB_xG9FtqweMeZ_6Hwf-w@cipher.nrlssc.navy.mil>
In-Reply-To: <7v3akyi07f.fsf@gitster.siamese.dyndns.org>

Junio C Hamano wrote:

Show 7 quoted lines

> Brandon Casey <casey@nrlssc.navy.mil> writes:
> 
>> Junio complained that my initial version of this was fragile which has
>> similarities with the above. Initially, I was blindly changing the first line
>> to contain "object...", second line to "type...", etc.
> 
> Was it more about not limiting the munging to only the header part?

No. I originally had something like

   1c\object $new_sha1
   2c\tag commit
   ...

blindly changing line one to "object ...", line two to "tag ..." etc. That aspect is what you commented about. So it would have modified the proper parts of a well-formed tag.

I took your comments to be concerned with future proofing or dealing with a corrupt/flawed tag (allowing the flaws to propagate so mktag would error out), but you didn't state that explicitly.

You also educated me about addresses like 1,/regex/ which was used to limit the munging to only the header part.

> In
> any case, I think what Hannes has in the patch is fine (although I did not
> look the lines that follow outside the context).

That's fine.

-brandon