Re: [PATCH] filter-branch: Grok special characters in tag names

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 21, 2008, 20:26 UTC
Message-ID: <7v3akyi07f.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <NWVPkDIELqWBHTU58gfzDqO8HR575ZDJVO2pYdPMtqv9aBLzMLvyZg@cipher.nrlssc.navy.mil>

Brandon Casey <casey@nrlssc.navy.mil> writes:

> Junio complained that my initial version of this was fragile which has
> similarities with the above. Initially, I was blindly changing the first line
> to contain "object...", second line to "type...", etc.

Was it more about not limiting the munging to only the header part? In any case, I think what Hannes has in the patch is fine (although I did not look the lines that follow outside the context).

> Would something like the following be equivalent _and_ clearer? Emphasis
> on "and" because both are necessary, not because I strongly feel it to
> be so.

I was bitten by a/i/c followed by literal text that behave differently with various implementations of sed, and learned to stay away from the construct long time ago. Things might have gotten better these days, but old habit and gut-reaction is hard to shake off.